arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-26 08:08:51 +00:00
Code Issues Releases Wiki Activity

Add unit test for process_slip39 function (#601)

Browse Source 
Add unit test for process_slip39 function
This commit is contained in:
Tomas Susanka 2019-10-04 21:57:37 +02:00 committed by GitHub
commit 29bb2dcb95
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 113 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/apps/management/recovery_device/recover.py
View File

@ -56,8 +56,12 @@ def process_slip39(words: str) -> Tuple[Optional[bytes], slip39.Share]:
# These should be checked by UI before so it's a Runtime exception otherwise
if share.identifier != storage.recovery.get_slip39_identifier():
raise RuntimeError("Slip39: Share identifiers do not match")
if share.iteration_exponent != storage.recovery.get_slip39_iteration_exponent():
raise RuntimeError("Slip39: Share exponents do not match")
if storage.recovery_shares.get(share.index, share.group_index):
raise RuntimeError("Slip39: This mnemonic was already entered")
if share.group_count != storage.recovery.get_slip39_group_count():
raise RuntimeError("Slip39: Group count does not match")
remaining_for_share = (
storage.recovery.get_slip39_remaining_shares(share.group_index)

111
core/tests/test_apps.management.recovery_device.py
View File

@ -25,13 +25,120 @@ MNEMONIC_SLIP39_ADVANCED_33 = [
class TestSlip39(unittest.TestCase):
@mock_storage
def test_process_slip39(self):
def test_process_slip39_basic(self):
storage.recovery.set_in_progress(True)
words = MNEMONIC_SLIP39_BASIC_20_3of6[0]
# first share (member index 5)
first = MNEMONIC_SLIP39_BASIC_20_3of6[0]
secret, share = process_slip39(first)
self.assertIsNone(secret)
self.assertEqual(share.group_count, storage.recovery.get_slip39_group_count())
self.assertEqual(share.iteration_exponent, storage.recovery.get_slip39_iteration_exponent())
self.assertEqual(share.identifier, storage.recovery.get_slip39_identifier())
self.assertEqual(storage.recovery.get_slip39_remaining_shares(0), 2)
self.assertEqual(storage.recovery_shares.get(share.index, share.group_index), first)
# second share (member index 0)
second = MNEMONIC_SLIP39_BASIC_20_3of6[1]
secret, share = process_slip39(second)
self.assertIsNone(secret)
self.assertEqual(storage.recovery.get_slip39_remaining_shares(0), 1)
self.assertEqual(storage.recovery_shares.get(share.index, share.group_index), second)
self.assertEqual(storage.recovery_shares.fetch_group(share.group_index), [second, first]) # ordered by index
# third share (member index 3)
third = MNEMONIC_SLIP39_BASIC_20_3of6[2]
secret, share = process_slip39(third)
self.assertEqual(secret, b'I\x1by[\x80\xfc!\xcc\xdfFl\x0f\xbc\x98\xc8\xfc')
self.assertEqual(storage.recovery.get_slip39_remaining_shares(0), 0)
self.assertEqual(storage.recovery_shares.get(share.index, share.group_index), third)
self.assertEqual(storage.recovery_shares.fetch_group(share.group_index), [second, third, first]) # ordered by index
@mock_storage
def test_process_slip39_advanced(self):
storage.recovery.set_in_progress(True)
# complete group 1 (1of1)
words = MNEMONIC_SLIP39_ADVANCED_20[0]
secret, share = process_slip39(words)
self.assertIsNone(secret)
self.assertEqual(share.group_count, storage.recovery.get_slip39_group_count())
self.assertEqual(share.iteration_exponent, storage.recovery.get_slip39_iteration_exponent())
self.assertEqual(share.identifier, storage.recovery.get_slip39_identifier())
self.assertEqual(storage.recovery.fetch_slip39_remaining_shares(), [16, 0, 16, 16])
self.assertEqual(storage.recovery_shares.get(share.index, share.group_index), words)
# member index 4 from group 2 (3of5)
words = MNEMONIC_SLIP39_ADVANCED_20[1]
secret, share = process_slip39(words)
self.assertIsNone(secret)
self.assertEqual(share.group_count, storage.recovery.get_slip39_group_count())
self.assertEqual(share.iteration_exponent, storage.recovery.get_slip39_iteration_exponent())
self.assertEqual(share.identifier, storage.recovery.get_slip39_identifier())
self.assertEqual(storage.recovery_shares.get(share.index, share.group_index), words)
self.assertEqual(storage.recovery_shares.fetch_group(1), [MNEMONIC_SLIP39_ADVANCED_20[0]])
self.assertEqual(storage.recovery_shares.fetch_group(2), [MNEMONIC_SLIP39_ADVANCED_20[1]])
self.assertEqual(storage.recovery.fetch_slip39_remaining_shares(), [16, 0, 2, 16])
# member index 2 from group 2
words = MNEMONIC_SLIP39_ADVANCED_20[2]
secret, share = process_slip39(words)
self.assertIsNone(secret)
self.assertEqual(share.group_count, storage.recovery.get_slip39_group_count())
self.assertEqual(share.iteration_exponent, storage.recovery.get_slip39_iteration_exponent())
self.assertEqual(share.identifier, storage.recovery.get_slip39_identifier())
self.assertEqual(storage.recovery_shares.get(share.index, share.group_index), words)
self.assertEqual(storage.recovery_shares.fetch_group(1), [MNEMONIC_SLIP39_ADVANCED_20[0]])
self.assertEqual(storage.recovery_shares.fetch_group(2), [MNEMONIC_SLIP39_ADVANCED_20[2], MNEMONIC_SLIP39_ADVANCED_20[1]])
self.assertEqual(storage.recovery.fetch_slip39_remaining_shares(), [16, 0, 1, 16])
# last member index 0 from group 2
# now group 2 is complete => the whole Shamir recovery is completed
words = MNEMONIC_SLIP39_ADVANCED_20[3]
secret, share = process_slip39(words)
self.assertEqual(secret, b'\xc2\xd2\xe2j\xd0`#\xc6\x01E\xf1P\xab\xe2\xdd+')
self.assertEqual(share.group_count, storage.recovery.get_slip39_group_count())
self.assertEqual(share.iteration_exponent, storage.recovery.get_slip39_iteration_exponent())
self.assertEqual(share.identifier, storage.recovery.get_slip39_identifier())
self.assertEqual(storage.recovery_shares.get(share.index, share.group_index), words)
self.assertEqual(storage.recovery_shares.fetch_group(1), [MNEMONIC_SLIP39_ADVANCED_20[0]])
self.assertEqual(storage.recovery_shares.fetch_group(2), [MNEMONIC_SLIP39_ADVANCED_20[3], MNEMONIC_SLIP39_ADVANCED_20[2], MNEMONIC_SLIP39_ADVANCED_20[1]])
self.assertEqual(storage.recovery.fetch_slip39_remaining_shares(), [16, 0, 0, 16])
@mock_storage
def test_exceptions(self):
storage.recovery.set_in_progress(True)
words = MNEMONIC_SLIP39_BASIC_20_3of6[0]
secret, share = process_slip39(words)
self.assertIsNone(secret)
# same mnemonic
words = MNEMONIC_SLIP39_BASIC_20_3of6[0]
with self.assertRaises(RuntimeError):
secret, share = process_slip39(words)
self.assertIsNone(secret)
# identifier mismatch
words = MNEMONIC_SLIP39_ADVANCED_20[0]
with self.assertRaises(RuntimeError):
secret, share = process_slip39(words)
self.assertIsNone(secret)
# same identifier but different group settings
words = MNEMONIC_SLIP39_BASIC_20_3of6[0]
w = words.split()
w[2] = "check" # change the group settings
w[3] = "mortgage"
w[17] = "garden" # modify checksum accordingly
w[18] = "merchant"
w[19] = "merchant"
words = " ".join(w)
with self.assertRaises(RuntimeError):
secret, share = process_slip39(words)
self.assertIsNone(secret)
if __name__ == "__main__":