fix(tests/ui): fix failing master diffs

tests/ui_tests/common.py

@@ -7,7 +7,7 @@ import shutil
 import typing as t
 import warnings
 from copy import deepcopy
-from dataclasses import asdict, dataclass, field
+from dataclasses import asdict, dataclass, field, replace
 from difflib import SequenceMatcher
 from functools import cached_property
 from itertools import zip_longest
@@ -256,6 +256,11 @@ class TestCase:
     def fixtures_name(self) -> str:
         return f"{self.model}_{self.language}_{self.name}"
 
+    @classmethod
+    def from_fixtures(cls, fixtures_name: str, group: str) -> Self:
+        model, lang, name = fixtures_name.split("_", maxsplit=2)
+        return cls(model=model, group=group, name=name, language=lang)
+
     @property
     def dir(self) -> Path:
         return SCREENS_DIR / self.id
@@ -292,6 +297,9 @@ class TestCase:
         result.save_metadata()
         return result
 
+    def replace(self, **kwargs) -> Self:
+        return replace(self, **kwargs)
+
 
 @dataclass
 class TestResult:

tests/ui_tests/reporting/common.py

@@ -8,6 +8,7 @@ from dominate.tags import a, h1, hr, i, p, script, table, td, th, tr
 from ..common import (
     UI_TESTS_DIR,
     FixturesType,
+    TestCase,
     get_screen_path,
     screens_and_hashes,
     screens_diff,
@@ -27,6 +28,12 @@ MASTER_CACHE_DIR = HERE / "master_cache"
 if not MASTER_CACHE_DIR.exists():
     MASTER_CACHE_DIR.mkdir()
 
+LEGACY_MODEL_NAMES = {
+    "T1": "T1B1",
+    "TT": "T2T1",
+    "TR": "T2B1",
+}
+
 
 def generate_master_diff_report(
     diff_tests: dict[str, tuple[str, str]], base_dir: Path
@@ -40,7 +47,7 @@ def get_diff(
     print_to_console: bool = False,
     models: list[str] | None = None,
 ) -> tuple[dict[str, str], dict[str, str], dict[str, tuple[str, str]]]:
-    master = _get_preprocessed_master_fixtures()
+    master = _preprocess_master_compat(download.fetch_fixtures_master())
 
     removed = {}
     added = {}
@@ -57,9 +64,9 @@ def get_diff(
             current_tests = current_groups.get(group, {})
 
             def testname(test: str) -> str:
-                assert test.startswith(model + "_")
+                case = TestCase.from_fixtures(test, group)
-                test = test[len(model) + 1 :]
+                model = LEGACY_MODEL_NAMES.get(case.model, case.model)
-                return f"{model}-{group}-{test}"
+                return case.replace(model=model).id
 
             # removed items
             removed_here = {
@@ -123,21 +130,24 @@ def document(
 
 
 def _preprocess_master_compat(master_fixtures: dict[str, Any]) -> FixturesType:
-    if all(isinstance(v, str) for v in master_fixtures.values()):
+    new_fixtures = {}
-        # old format, convert to new format
+    for model, groups_by_model in master_fixtures.items():
-        new_fixtures = {}
+        if model not in LEGACY_MODEL_NAMES:
-        for key, val in master_fixtures.items():
+            new_fixtures[model] = groups_by_model
-            model, _test = key.split("_", maxsplit=1)
+            continue
-            groups_by_model = new_fixtures.setdefault(model, {})
-            default_group = groups_by_model.setdefault("device_tests", {})
-            default_group[key] = val
-        return FixturesType(new_fixtures)
-    else:
-        return FixturesType(master_fixtures)
 
+        # (a) replace model group name
+        model = LEGACY_MODEL_NAMES.get(model)
+        new_groups_by_model = new_fixtures.setdefault(model, {})
+        for group, tests_by_group in groups_by_model.items():
+            new_tests_by_group = new_groups_by_model.setdefault(group, {})
+            for key, val in tests_by_group.items():
+                case = TestCase.from_fixtures(key, group)
+                # (b) in individual testcases, replace model name prefix
+                new_case = case.replace(model=model)
+                new_tests_by_group[new_case.fixtures_name] = val
 
-def _get_preprocessed_master_fixtures() -> FixturesType:
+    return FixturesType(new_fixtures)
-    return _preprocess_master_compat(download.fetch_fixtures_master())
 
 
 def _create_testcase_html_diff_file(