arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-18 12:28:09 +00:00
Code Issues Releases Wiki Activity

feat(python): Raise ValueError for non-existant tx hashes

Browse Source 
If the device asks for a tx_hash which is not present in prev_txes,
raise a ValueError with some more detailed messaging about the missing
hash rather than the default dictionary lookup failure of KeyError.
This commit is contained in:
Andrew Chow 2021-02-01 21:26:14 -05:00 committed by matejcik
parent ff7d5c224b
commit 23a09fc047
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
python/.changelog.d/1442.changed Normal file
View File

@ -0,0 +1 @@
Raise `ValueError` when the txid for an input is not present in `prev_txes` during `btc.sign_tx`

4
python/src/trezorlib/btc.py
View File

@ -334,6 +334,10 @@ def sign_tx(
# Device asked for one more information, let's process it. # Device asked for one more information, let's process it.
if res.details.tx_hash is not None: if res.details.tx_hash is not None:
if res.details.tx_hash not in prev_txes:
raise ValueError(
f"Previous transaction {res.details.tx_hash.hex()} not available"
)
current_tx = prev_txes[res.details.tx_hash] current_tx = prev_txes[res.details.tx_hash]
else: else:
current_tx = this_tx current_tx = this_tx