arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-06-17 21:48:47 +00:00
Code Issues Releases Wiki Activity

fix(core): use bool for _ignore_loader_messages

Browse Source 
Since `trezor.pin` is persisted across sessions, it should use constant-size globals.

[no changelog]
This commit is contained in:
Roman Zeyde 2025-05-02 12:53:35 +03:00
parent 42c4cf5190
commit 1f8ebc3562
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
core/src/trezor/pin.py
View File

@ -3,7 +3,7 @@ from typing import TYPE_CHECKING
from . import config from . import config
if TYPE_CHECKING: if TYPE_CHECKING:
from typing import Any, Container from typing import Any
from trezor.ui import ProgressLayout from trezor.ui import ProgressLayout
@ -13,20 +13,17 @@ _progress_layout: ProgressLayout | None = None
_started_with_empty_loader = False _started_with_empty_loader = False
keepalive_callback: Any = None keepalive_callback: Any = None
_ignore_loader_messages: Container[config.StorageMessage] = () _ignore_loader_messages: bool = False
def ignore_nonpin_loader_messages() -> None: def ignore_nonpin_loader_messages() -> None:
global _ignore_loader_messages global _ignore_loader_messages
_ignore_loader_messages = ( _ignore_loader_messages = True
config.StorageMessage.PROCESSING_MSG,
config.StorageMessage.STARTING_MSG,
)
def allow_all_loader_messages() -> None: def allow_all_loader_messages() -> None:
global _ignore_loader_messages global _ignore_loader_messages
_ignore_loader_messages = () _ignore_loader_messages = False
def render_empty_loader(message: config.StorageMessage, description: str = "") -> None: def render_empty_loader(message: config.StorageMessage, description: str = "") -> None:
@ -49,7 +46,10 @@ def show_pin_timeout(
from trezor.ui.layouts.progress import pin_progress from trezor.ui.layouts.progress import pin_progress
# Possibility to ignore certain messages - not showing loader for them # Possibility to ignore certain messages - not showing loader for them
if message in _ignore_loader_messages: if _ignore_loader_messages and message in (
config.StorageMessage.PROCESSING_MSG,
config.StorageMessage.STARTING_MSG,
):
return False return False
global _previous_seconds global _previous_seconds