1
0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-18 04:18:10 +00:00

ci: always post UI report comment

This commit is contained in:
Martin Milata 2024-11-08 21:46:30 +01:00
parent b40ce852ea
commit 1c7e8d5391
2 changed files with 2 additions and 22 deletions

View File

@ -286,8 +286,6 @@ jobs:
status: ${{ job.status }}
if: ${{ always() && env.ACTIONS_DO_UI_TEST == 'true' }}
continue-on-error: true
- uses: ./.github/actions/ui-comment
if: ${{ failure() && env.ACTIONS_DO_UI_TEST == 'true' }}
- uses: ./.github/actions/upload-coverage
# Click tests - UI.
@ -705,19 +703,11 @@ jobs:
core_ui_comment:
name: Post comment with UI diff URLs
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- run: |
git fetch origin main
git diff --quiet origin/main...HEAD -- tests/ui_tests/fixtures.json || echo "FIXTURES_CHANGED=$?" >> $GITHUB_OUTPUT
id: check-fixtures-changed
- uses: ./.github/actions/ui-comment
# TODO: always run if comment already exists
if: ${{ steps.check-fixtures-changed.outputs.FIXTURES_CHANGED == '1' }}
core_upload_emu:
name: Upload emulator binaries

View File

@ -134,8 +134,6 @@ jobs:
status: ${{ job.status }}
continue-on-error: true
if: ${{ always() && matrix.coins == 'universal' }}
- uses: ./.github/actions/ui-comment
if: ${{ failure() && matrix.coins == 'universal' }}
legacy_upgrade_test:
name: Upgrade test
@ -216,19 +214,11 @@ jobs:
legacy_ui_comment:
name: Post comment with UI diff URLs
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
ref: ${{ github.event.pull_request.head.sha }}
- run: |
git fetch origin main
git diff --quiet origin/main...HEAD -- tests/ui_tests/fixtures.json || echo "FIXTURES_CHANGED=$?" >> $GITHUB_OUTPUT
id: check-fixtures-changed
- uses: ./.github/actions/ui-comment
# TODO: always run if comment already exists
if: ${{ steps.check-fixtures-changed.outputs.FIXTURES_CHANGED == '1' }}
legacy_upload_emu:
name: Upload emulator binaries