arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-18 20:38:10 +00:00
Code Issues Releases Wiki Activity

fix(core/stellar): fail cleanly when asset code has wrong length

Browse Source
This commit is contained in:
matejcik 2021-07-19 15:10:50 +02:00 committed by matejcik
parent ad6976e01f
commit 16b87e4d50
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/src/apps/stellar/operations/serialize.py
View File

@ -12,7 +12,7 @@ from trezor.messages import (
StellarPaymentOp, StellarPaymentOp,
StellarSetOptionsOp, StellarSetOptionsOp,
) )
from trezor.wire import ProcessError from trezor.wire import DataError, ProcessError
from .. import consts, writers from .. import consts, writers
@ -148,9 +148,13 @@ def _write_asset_code(w, asset_type: int, asset_code: str):
if asset_type == consts.ASSET_TYPE_NATIVE: if asset_type == consts.ASSET_TYPE_NATIVE:
return # nothing is needed return # nothing is needed
elif asset_type == consts.ASSET_TYPE_ALPHANUM4: elif asset_type == consts.ASSET_TYPE_ALPHANUM4:
if len(code) > 4:
raise DataError("Stellar: asset code too long for ALPHANUM4")
# pad with zeros to 4 chars # pad with zeros to 4 chars
writers.write_bytes_fixed(w, code + bytearray([0] * (4 - len(code))), 4) writers.write_bytes_fixed(w, code + bytearray([0] * (4 - len(code))), 4)
elif asset_type == consts.ASSET_TYPE_ALPHANUM12: elif asset_type == consts.ASSET_TYPE_ALPHANUM12:
if len(code) > 12:
raise DataError("Stellar: asset code too long for ALPHANUM12")
# pad with zeros to 12 chars # pad with zeros to 12 chars
writers.write_bytes_fixed(w, code + bytearray([0] * (12 - len(code))), 12) writers.write_bytes_fixed(w, code + bytearray([0] * (12 - len(code))), 12)
else: else: