tests/device_tests: remove all star imports

trezorlib/tests/device_tests/test_basic.py

@@ -16,7 +16,7 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from .common import *
+from .common import TrezorTest
 
 from trezorlib import messages
 

trezorlib/tests/device_tests/test_bip32_speed.py

@@ -15,11 +15,10 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
-
-from __future__ import print_function
-
-from .common import *
 import time
+import pytest
+
+from .common import TrezorTest
 
 
 class TestBip32Speed(TrezorTest):

trezorlib/tests/device_tests/test_debuglink.py

@@ -15,9 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
-
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_msg_applysettings.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
+from .common import TrezorTest
 
 import time
 from trezorlib import messages as proto

trezorlib/tests/device_tests/test_msg_changepin.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
+from .common import TrezorTest
 
 from trezorlib import messages as proto
 

trezorlib/tests/device_tests/test_msg_cipherkeyvalue.py

@@ -15,8 +15,10 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import hexlify, unhexlify
+import pytest
 
-from .common import *
+from .common import TrezorTest
 
 
 class TestMsgCipherkeyvalue(TrezorTest):

trezorlib/tests/device_tests/test_msg_clearsession.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
+from .common import TrezorTest
 
 from trezorlib import messages as proto
 

trezorlib/tests/device_tests/test_msg_ethereum_getaddress.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import hexlify
 
-from .common import *
+from .common import TrezorTest
 
 
 class TestMsgEthereumGetaddress(TrezorTest):

trezorlib/tests/device_tests/test_msg_ethereum_signmessage.py

@@ -14,8 +14,10 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import hexlify
+import pytest
 
-from .common import *
+from .common import TrezorTest
 
 
 @pytest.mark.skip_t2

trezorlib/tests/device_tests/test_msg_ethereum_signtx.py

@@ -15,8 +15,11 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify, hexlify
 
-from .common import *
+import pytest
+
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_msg_ethereum_verifymessage.py

@@ -14,8 +14,11 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify
 
-from .common import *
+import pytest
+
+from .common import TrezorTest
 
 
 @pytest.mark.skip_t2

trezorlib/tests/device_tests/test_msg_getecdhsessionkey.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify
 
-from .common import *
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_msg_getentropy.py

@@ -16,10 +16,9 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from __future__ import print_function
 
 import math
-from .common import *
+from .common import TrezorTest
 
 import trezorlib.messages as proto
 

trezorlib/tests/device_tests/test_msg_loaddevice.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
+from .common import TrezorTest
 
 
 @pytest.mark.skip_t2

trezorlib/tests/device_tests/test_msg_loaddevice_xprv.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
+from .common import TrezorTest
 
 
 @pytest.mark.skip_t2

trezorlib/tests/device_tests/test_msg_ping.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
+from .common import TrezorTest
 
 from trezorlib import messages as proto
 

trezorlib/tests/device_tests/test_msg_recoverydevice.py

@@ -16,9 +16,9 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from __future__ import print_function
+import pytest
 
-from .common import *
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_msg_recoverydevice_dryrun.py

@@ -16,9 +16,9 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from __future__ import print_function
+import pytest
 
-from .common import *
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_msg_recoverydevice_t2.py

@@ -16,11 +16,12 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from __future__ import print_function
 
 import time
 
-from .common import *
+import pytest
+
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_msg_resetdevice.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
+from .common import TrezorTest, generate_entropy
 
 from trezorlib import messages as proto
 from mnemonic import Mnemonic

trezorlib/tests/device_tests/test_msg_resetdevice_skipbackup.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+import pytest
 
-from .common import *
+from .common import TrezorTest, generate_entropy
 from trezorlib import messages as proto
 from mnemonic import Mnemonic
 

trezorlib/tests/device_tests/test_msg_resetdevice_t2.py

@@ -17,8 +17,9 @@
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
 import time
+import pytest
 
-from .common import *
+from .common import TrezorTest, generate_entropy
 
 from trezorlib import messages as proto
 from mnemonic import Mnemonic

trezorlib/tests/device_tests/test_msg_signidentity.py

@@ -16,10 +16,11 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from __future__ import print_function
 
 import struct
-from .common import *
+from binascii import hexlify, unhexlify
+
+from .common import TrezorTest
 
 from trezorlib import messages as proto
 

trezorlib/tests/device_tests/test_msg_signmessage.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import hexlify
 
-from .common import *
+from .common import TrezorTest
 
 
 class TestMsgSignmessage(TrezorTest):

trezorlib/tests/device_tests/test_msg_signmessage_segwit.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import hexlify
 
-from .common import *
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_msg_signmessage_segwit_native.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import hexlify
 
-from .common import *
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_msg_signtx_decred.py

@@ -15,7 +15,7 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from binascii import hexlify, unhexlify
+from binascii import unhexlify
 import pytest
 
 from .common import TrezorTest

trezorlib/tests/device_tests/test_msg_signtx_zcash.py

@@ -15,12 +15,14 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify, hexlify
+import pytest
 
-
-from .common import *
+from .common import TrezorTest
 
 from trezorlib import coins
 from trezorlib import messages as proto
+from trezorlib.tools import parse_path
 
 TxApiZcash = coins.tx_api["Zcash"]
 
@@ -28,8 +30,7 @@ TxApiZcash = coins.tx_api["Zcash"]
 TXHASH_93373e = unhexlify('93373e63cc626c4a7d049ad775d6511bb5eba985f142db660c9b9f955c722f5c')
 
 
-@pytest.mark.skip_t1
-@pytest.mark.skip_t2
+@pytest.mark.skip(reason="Broken until we have support for Zcash v3 transactions.")
 class TestMsgSigntxZcash(TrezorTest):
 
     def test_one_one_fee(self):
@@ -39,7 +40,7 @@ class TestMsgSigntxZcash(TrezorTest):
         # input 0: 1.234567 TAZ
 
         inp1 = proto.TxInputType(
-            address_n=[2147483692, 2147483649, 2147483648, 0, 0],  # tmQoJ3PTXgQLaRRZZYT6xk8XtjRbr2kCqwu
+            address_n=parse_path("m/Zcash Testnet/0h/0/0"),  # tmQoJ3PTXgQLaRRZZYT6xk8XtjRbr2kCqwu
             # amount=123456700,
             prev_hash=TXHASH_93373e,
             prev_index=0,

trezorlib/tests/device_tests/test_msg_verifymessage.py

@@ -15,9 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify
 
-from .common import *
-import base64
+from .common import TrezorTest
 
 
 class TestMsgVerifymessage(TrezorTest):

trezorlib/tests/device_tests/test_msg_verifymessage_segwit.py

@@ -15,9 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify
 
-from .common import *
-import base64
+from .common import TrezorTest
 
 
 class TestMsgVerifymessageSegwit(TrezorTest):

trezorlib/tests/device_tests/test_msg_verifymessage_segwit_native.py

@@ -15,9 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify
 
-from .common import *
-import base64
+from .common import TrezorTest
 
 
 class TestMsgVerifymessageSegwitNative(TrezorTest):

trezorlib/tests/device_tests/test_msg_wipedevice.py

@@ -16,7 +16,7 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from .common import *
+from .common import TrezorTest
 
 from trezorlib import messages as proto
 

trezorlib/tests/device_tests/test_op_return.py

@@ -15,8 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify, hexlify
 
-from .common import *
+from .common import TrezorTest
 
 from trezorlib import messages as proto
 from trezorlib.client import CallException

trezorlib/tests/device_tests/test_protect_call.py

@@ -16,10 +16,10 @@
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
 
-from __future__ import print_function
-
 import time
-from .common import *
+import pytest
+
+from .common import TrezorTest
 from trezorlib import messages as proto
 from trezorlib.client import PinException, CallException
 

trezorlib/tests/device_tests/test_protection_levels.py

@@ -15,8 +15,10 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify
+import pytest
 
-from .common import *
+from .common import TrezorTest
 from trezorlib import messages as proto
 
 

trezorlib/tests/device_tests/test_zerosig.py

@@ -15,12 +15,9 @@
 #
 # You should have received a copy of the GNU Lesser General Public License
 # along with this library.  If not, see <http://www.gnu.org/licenses/>.
+from binascii import unhexlify
 
-from __future__ import print_function
-
-import sys
-from .common import *
-
+from .common import TrezorTest
 from trezorlib import messages as proto