arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-01-31 09:50:58 +00:00
Code Issues Releases Wiki Activity

fix(python): increase homescreen quality when uploading via trezorctl

Browse Source 
fixes #3893
This commit is contained in:
matejcik 2024-06-12 11:50:41 +02:00
parent 6338ba994a
commit 0fc193ab80
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
python/.changelog.d/3893.added Normal file
View File

@ -0,0 +1 @@
Added `--quality` argument to `trezorctl set homescreen`.

1
python/.changelog.d/3893.changed Normal file
View File

@ -0,0 +1 @@
Increased default JPEG quality for uploaded homescreen.

9
python/src/trezorlib/cli/settings.py
View File

@ -117,7 +117,7 @@ def image_to_toif(filename: Path, width: int, height: int, greyscale: bool) -> b
return toif_image.to_bytes() return toif_image.to_bytes()
def image_to_jpeg(filename: Path, width: int, height: int) -> bytes: def image_to_jpeg(filename: Path, width: int, height: int, quality: int = 90) -> bytes:
if filename.suffix in (".jpg", ".jpeg") and not PIL_AVAILABLE: if filename.suffix in (".jpg", ".jpeg") and not PIL_AVAILABLE:
click.echo("Warning: Image library is missing, skipping image validation.") click.echo("Warning: Image library is missing, skipping image validation.")
return filename.read_bytes() return filename.read_bytes()
@ -147,7 +147,7 @@ def image_to_jpeg(filename: Path, width: int, height: int) -> bytes:
image = image.convert("RGB") image = image.convert("RGB")
buf = io.BytesIO() buf = io.BytesIO()
image.save(buf, format="jpeg", progressive=False) image.save(buf, format="jpeg", progressive=False, quality=quality)
return buf.getvalue() return buf.getvalue()
@ -307,8 +307,9 @@ def flags(client: "TrezorClient", flags: str) -> str:
@click.option( @click.option(
"-f", "--filename", "_ignore", is_flag=True, hidden=True, expose_value=False "-f", "--filename", "_ignore", is_flag=True, hidden=True, expose_value=False
) )
@click.option("-q", "--quality", type=int, default=90, help="JPEG quality (0-100)")
@with_client @with_client
def homescreen(client: "TrezorClient", filename: str) -> str: def homescreen(client: "TrezorClient", filename: str, quality: int) -> str:
"""Set new homescreen. """Set new homescreen.
To revert to default homescreen, use 'trezorctl set homescreen default' To revert to default homescreen, use 'trezorctl set homescreen default'
@ -334,7 +335,7 @@ def homescreen(client: "TrezorClient", filename: str) -> str:
if client.features.homescreen_height is not None if client.features.homescreen_height is not None
else 240 else 240
) )
img = image_to_jpeg(path, width, height) img = image_to_jpeg(path, width, height, quality)
elif client.features.homescreen_format == messages.HomescreenFormat.ToiG: elif client.features.homescreen_format == messages.HomescreenFormat.ToiG:
width = client.features.homescreen_width width = client.features.homescreen_width
height = client.features.homescreen_height height = client.features.homescreen_height