arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-12-23 06:48:16 +00:00
Code Issues Releases Wiki Activity

chore(core): Reject replacement transactions which involve negative

Browse Source 
fees.
This commit is contained in:
Andrew Kozlik 2020-12-01 10:08:38 +01:00 committed by Andrew Kozlik
parent 3be0138aae
commit 06ce14096c
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/apps/bitcoin/sign_tx/approvers.py
View File

@ -151,6 +151,11 @@ class BasicApprover(Approver):
)
orig_fee = self.orig_total_in - self.orig_total_out
if fee < 0 or orig_fee < 0:
raise wire.ProcessError(
"Negative fees not supported in transaction replacement."
)
# Replacement transactions are only allowed to make amendments which
# do not increase the amount that we are spending on external outputs.
# In other words, the total amount being sent out of the wallet must