arno/trezor-firmware
1
0
Fork 0
mirror of https://github.com/trezor/trezor-firmware.git synced 2024-11-15 20:19:23 +00:00
Code Issues Releases Wiki Activity

stellar: typos based on code review

Browse Source
This commit is contained in:
Tomas Susanka 2018-07-11 15:40:32 +02:00
parent b46ce034d6
commit 0666533ca0
3 changed files with 13 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/apps/stellar/README.md
View File

@ -7,10 +7,3 @@ AUTHOR = Tomas Susanka <tomas.susanka@satoshilabs.com>
REVIEWER = Jan Pochyla <jan.pochyla@satoshilabs.com>
-----
TODO
# Stellar transactions consist of sha256 of:
# - sha256(network passphrase)
# - 4-byte unsigned big-endian int type constant (2 for tx)
# - public key

29
src/apps/stellar/layout.py
View File

@ -20,20 +20,20 @@ async def require_confirm_init(ctx, address: str, network_passphrase: str):
async def require_confirm_memo(ctx, memo_type: int, memo_text: str):
if memo_type == consts.MEMO_TYPE_TEXT:
title = "Memo (TEXT)"
elif memo_type == consts.MEMO_TYPE_ID:
title = "Memo (ID)"
elif memo_type == consts.MEMO_TYPE_HASH:
title = "Memo (HASH)"
elif memo_type == consts.MEMO_TYPE_RETURN:
title = "Memo (RETURN)"
else: # MEMO_TYPE_NONE
title = "No memo set!" # todo format this as ui.NORMAL not MONO
memo_text = "Important: Many exchanges require a memo when depositing"
text = Text("Confirm memo", ui.ICON_CONFIRM, icon_color=ui.GREEN)
text.bold(title)
text.mono(*split(memo_text))
if memo_type == consts.MEMO_TYPE_TEXT:
text.bold("Memo (TEXT)")
elif memo_type == consts.MEMO_TYPE_ID:
text.bold("Memo (ID)")
elif memo_type == consts.MEMO_TYPE_HASH:
text.bold("Memo (HASH)")
elif memo_type == consts.MEMO_TYPE_RETURN:
text.bold("Memo (RETURN)")
else: # MEMO_TYPE_NONE
text.bold("No memo set!")
text.normal("Important: Many exchanges require a memo when depositing")
if memo_type != consts.MEMO_TYPE_NONE:
text.mono(*split(memo_text))
await require_confirm(ctx, text, ButtonRequestType.ConfirmOutput)
@ -57,12 +57,10 @@ def format_amount(amount: int, ticker=True) -> str:
return utils.format_amount(amount, consts.AMOUNT_DIVISIBILITY) + t
# todo merge with nem
def split(text):
return utils.chunks(text, 17)
# todo merge with nem
def trim(payload: str, length: int, dots=True) -> str:
if len(payload) > length:
if dots:
@ -71,7 +69,6 @@ def trim(payload: str, length: int, dots=True) -> str:
return payload
# todo merge with nem
def trim_to_rows(payload: str, rows: int = 1) -> str:
return trim(payload, rows * 17)

6
src/apps/stellar/sign_tx.py
View File

@ -97,9 +97,3 @@ async def _memo(ctx, w: bytearray, msg: StellarSignTx):
else:
raise ProcessError("Stellar invalid memo type")
await layout.require_confirm_memo(ctx, msg.memo_type, memo_confirm_text)
def node_derive(root, address_n: list):
node = root.clone()
node.derive_path(address_n)
return node