1
0
mirror of https://github.com/trezor/trezor-firmware.git synced 2025-02-26 22:32:33 +00:00

legacy: replace confusing Version group ID error message

This commit is contained in:
Martin Milata 2020-09-04 12:47:37 +02:00 committed by Tomas Susanka
parent e9ed0851b3
commit 047fcffde1

View File

@ -1424,14 +1424,21 @@ void signing_txack(TransactionType *tx) {
signing_abort();
return;
}
if (coin->overwintered &&
(tx->version >= 3) != (tx->has_version_group_id)) {
fsm_sendFailure(FailureType_Failure_DataError,
_("Version group ID must be set when version >= 3."));
signing_abort();
return;
}
if (!coin->overwintered) {
if (coin->overwintered) {
if (tx->version >= 3 && !tx->has_version_group_id) {
fsm_sendFailure(FailureType_Failure_DataError,
_("Version group ID must be set when version >= 3."));
signing_abort();
return;
}
if (tx->version < 3 && tx->has_version_group_id) {
fsm_sendFailure(
FailureType_Failure_DataError,
_("Version group ID must be unset when version < 3."));
signing_abort();
return;
}
} else { // !coin->overwintered
if (tx->has_version_group_id) {
fsm_sendFailure(FailureType_Failure_DataError,
_("Version group ID not enabled on this coin."));