feat(core/ethereum): EIP-712
Based on original contribution by Max Kupriianov <xlab@hey.com>
Implemented EIP-712 typed data signatures in Ethereum app.
Add eth_abi into pyproject deps
device test for EIP 712
fixed hex decoding for address
fixup! fixed hex decoding for address
code quality, more pythonic code, removing unused imports
running black and isort on changed files
trezorctl file input for EIP 712 data signing
fixup! code quality, more pythonic code, removing unused imports
fixup! fixup! code quality, more pythonic code, removing unused imports
necessary changes after rebase to master
unit tests for sign_typed_data.py
new protobuf messages, working for nonarray types
simplified and verified solution for our simple data
support for simple arrays, without their confirmation
reverting protobuf value messages to bytes, appropriate changes
showing arrays in Trezor, code quality improvements
data validation on Trezor, minor improvements
using custom types for storing type data instead of dicts, addressing feedback from review
moving helper functions to its own file, tests for decode_data
additional overall tests
support for arrays of structs
adding support for metamask_v4_compat variable
using HashWriter object to collect the final hash continously
minor improvements in code quality
validate_field_type function
streaming values from client without saving them, missing UI
prototype of streamed UI using confirm_properties
accounting for bytes in data, more data types in integration tests
rebase on master, using f-strings
minor fixes and improvements from code review
StructHasher class for the whole hashing process
mypy and style changes
asking users whether to show structs and arrays
protobuf descriptions to fix make defs_check
unifying comments, mypy fix
unit tests for StructHasher class
UI fixtures, skipping device tests for T1
addressing majority of code review comments about code quality and structure
changing file structure - layouts, helpers, sign_typed_data
decode_data renaming and docstring, renaming unit test file
using tuples instead of lists in elifs
layout improvements
excluding core/src/apps/common/confirm.py file from the PR
True/False returning layout with Show more button
code review layout improvements
forgotten br_type argument to should_show_more
2021-04-12 20:38:07 +00:00
|
|
|
syntax = "proto2";
|
|
|
|
package hw.trezor.messages.ethereum_eip712;
|
|
|
|
|
|
|
|
// Sugar for easier handling in Java
|
|
|
|
option java_package = "com.satoshilabs.trezor.lib.protobuf";
|
|
|
|
option java_outer_classname = "TrezorMessageEthereumEIP712";
|
|
|
|
|
2023-02-03 13:38:42 +00:00
|
|
|
import "messages-ethereum-definitions.proto";
|
|
|
|
|
feat(core/ethereum): EIP-712
Based on original contribution by Max Kupriianov <xlab@hey.com>
Implemented EIP-712 typed data signatures in Ethereum app.
Add eth_abi into pyproject deps
device test for EIP 712
fixed hex decoding for address
fixup! fixed hex decoding for address
code quality, more pythonic code, removing unused imports
running black and isort on changed files
trezorctl file input for EIP 712 data signing
fixup! code quality, more pythonic code, removing unused imports
fixup! fixup! code quality, more pythonic code, removing unused imports
necessary changes after rebase to master
unit tests for sign_typed_data.py
new protobuf messages, working for nonarray types
simplified and verified solution for our simple data
support for simple arrays, without their confirmation
reverting protobuf value messages to bytes, appropriate changes
showing arrays in Trezor, code quality improvements
data validation on Trezor, minor improvements
using custom types for storing type data instead of dicts, addressing feedback from review
moving helper functions to its own file, tests for decode_data
additional overall tests
support for arrays of structs
adding support for metamask_v4_compat variable
using HashWriter object to collect the final hash continously
minor improvements in code quality
validate_field_type function
streaming values from client without saving them, missing UI
prototype of streamed UI using confirm_properties
accounting for bytes in data, more data types in integration tests
rebase on master, using f-strings
minor fixes and improvements from code review
StructHasher class for the whole hashing process
mypy and style changes
asking users whether to show structs and arrays
protobuf descriptions to fix make defs_check
unifying comments, mypy fix
unit tests for StructHasher class
UI fixtures, skipping device tests for T1
addressing majority of code review comments about code quality and structure
changing file structure - layouts, helpers, sign_typed_data
decode_data renaming and docstring, renaming unit test file
using tuples instead of lists in elifs
layout improvements
excluding core/src/apps/common/confirm.py file from the PR
True/False returning layout with Show more button
code review layout improvements
forgotten br_type argument to should_show_more
2021-04-12 20:38:07 +00:00
|
|
|
|
|
|
|
// Separated from messages-ethereum.proto as it is not implemented on T1 side
|
|
|
|
// and defining all the messages and fields could be even impossible as recursive
|
|
|
|
// messages are used here
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Request: Ask device to sign typed data
|
|
|
|
* @start
|
|
|
|
* @next EthereumTypedDataStructRequest
|
|
|
|
* @next EthereumTypedDataValueRequest
|
|
|
|
* @next EthereumTypedDataSignature
|
|
|
|
* @next Failure
|
|
|
|
*/
|
|
|
|
message EthereumSignTypedData {
|
2023-02-03 13:38:42 +00:00
|
|
|
repeated uint32 address_n = 1; // BIP-32 path to derive the key from master node
|
|
|
|
required string primary_type = 2; // name of the root message struct
|
|
|
|
optional bool metamask_v4_compat = 3 [default=true]; // use MetaMask v4 (see https://github.com/MetaMask/eth-sig-util/issues/106)
|
|
|
|
optional ethereum_definitions.EthereumDefinitions definitions = 4; // network and/or token definitions
|
feat(core/ethereum): EIP-712
Based on original contribution by Max Kupriianov <xlab@hey.com>
Implemented EIP-712 typed data signatures in Ethereum app.
Add eth_abi into pyproject deps
device test for EIP 712
fixed hex decoding for address
fixup! fixed hex decoding for address
code quality, more pythonic code, removing unused imports
running black and isort on changed files
trezorctl file input for EIP 712 data signing
fixup! code quality, more pythonic code, removing unused imports
fixup! fixup! code quality, more pythonic code, removing unused imports
necessary changes after rebase to master
unit tests for sign_typed_data.py
new protobuf messages, working for nonarray types
simplified and verified solution for our simple data
support for simple arrays, without their confirmation
reverting protobuf value messages to bytes, appropriate changes
showing arrays in Trezor, code quality improvements
data validation on Trezor, minor improvements
using custom types for storing type data instead of dicts, addressing feedback from review
moving helper functions to its own file, tests for decode_data
additional overall tests
support for arrays of structs
adding support for metamask_v4_compat variable
using HashWriter object to collect the final hash continously
minor improvements in code quality
validate_field_type function
streaming values from client without saving them, missing UI
prototype of streamed UI using confirm_properties
accounting for bytes in data, more data types in integration tests
rebase on master, using f-strings
minor fixes and improvements from code review
StructHasher class for the whole hashing process
mypy and style changes
asking users whether to show structs and arrays
protobuf descriptions to fix make defs_check
unifying comments, mypy fix
unit tests for StructHasher class
UI fixtures, skipping device tests for T1
addressing majority of code review comments about code quality and structure
changing file structure - layouts, helpers, sign_typed_data
decode_data renaming and docstring, renaming unit test file
using tuples instead of lists in elifs
layout improvements
excluding core/src/apps/common/confirm.py file from the PR
True/False returning layout with Show more button
code review layout improvements
forgotten br_type argument to should_show_more
2021-04-12 20:38:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Response: Device asks for type information about a struct.
|
|
|
|
* @next EthereumTypedDataStructAck
|
|
|
|
*/
|
|
|
|
message EthereumTypedDataStructRequest {
|
|
|
|
required string name = 1; // name of the requested struct
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Request: Type information about a struct.
|
|
|
|
* @next EthereumTypedDataStructRequest
|
|
|
|
*/
|
|
|
|
message EthereumTypedDataStructAck {
|
|
|
|
repeated EthereumStructMember members = 1;
|
|
|
|
|
|
|
|
message EthereumStructMember {
|
|
|
|
required EthereumFieldType type = 1;
|
|
|
|
required string name = 2;
|
|
|
|
}
|
|
|
|
|
|
|
|
message EthereumFieldType {
|
|
|
|
required EthereumDataType data_type = 1;
|
|
|
|
optional uint32 size = 2; // for integer types: size in bytes (uint8 has size 1, uint256 has size 32)
|
|
|
|
// for bytes types: size in bytes, or unset for dynamic
|
|
|
|
// for arrays: size in elements, or unset for dynamic
|
|
|
|
// for structs: number of members
|
|
|
|
// for string, bool and address: unset
|
|
|
|
optional EthereumFieldType entry_type = 3; // for array types, type of single entry
|
|
|
|
optional string struct_name = 4; // for structs: its name
|
|
|
|
}
|
|
|
|
|
|
|
|
enum EthereumDataType {
|
|
|
|
UINT = 1;
|
|
|
|
INT = 2;
|
|
|
|
BYTES = 3;
|
|
|
|
STRING = 4;
|
|
|
|
BOOL = 5;
|
|
|
|
ADDRESS = 6;
|
|
|
|
ARRAY = 7;
|
|
|
|
STRUCT = 8;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Response: Device asks for data at the specific member path.
|
|
|
|
* @next EthereumTypedDataValueAck
|
|
|
|
*/
|
|
|
|
message EthereumTypedDataValueRequest {
|
|
|
|
repeated uint32 member_path = 1; // member path requested by device
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Request: Single value of a specific atomic field.
|
|
|
|
* @next EthereumTypedDataValueRequest
|
|
|
|
*/
|
|
|
|
message EthereumTypedDataValueAck {
|
|
|
|
required bytes value = 1;
|
|
|
|
// * atomic types: value of the member.
|
|
|
|
// Length must match the `size` of the corresponding field type, unless the size is dynamic.
|
|
|
|
// * array types: number of elements, encoded as uint16.
|
|
|
|
// * struct types: undefined, Trezor will not query a struct field.
|
|
|
|
}
|