arno/isso
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
928 Commits 14 Branches 38 Tags 5.8 MiB
650c6cf126
Commit Graph

928 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Martin Zimmermann
650c6cf126 Merge pull request #341 from macedigital/fix-identicon-hash-size 
Fix: Truncate key-length when generating identicons
 2017-08-17 11:27:59 +02:00
Martin Zimmermann
6a60f831b0 remove unused variable 2017-08-17 10:42:36 +02:00
Martin Zimmermann
9b0e3d29fe revert incorrect removal of the internal server startup CLI 2017-08-17 10:37:28 +02:00
Matthias Adler
43623f349b
Fix: Truncate key-length when generating identicons 
Hex-digits with character count above 17 cannot be safely converted to an Integer, see [MAX_SAFE_INTEGER](https://medium.com/the-node-js-collection/javascripts-number-type-8d59199db1b6#53cd).

Therefore, when long keys (e.g. 32 characters) are passed into `generateIdenticon()`, and the modulus of 2^18 is performed, the result is 0 all the time. This means, the identicon will render as an empty svg image.

Here is a proof-of-concept (run in any modern browser):

```js
const key = '841b625dcf75413ff3ed5137a81ff1c3';
const int = parseInt(key, 16);
const hash = int % Math.pow(2, 18);
// throws, due to floating point conversion / integer overflow
console.assert(258499 === hash, "Modulus for 'hash' should be != 0");

const int2 = parseInt(key.substr(-16), 16);
const hash2 = int2 % Math.pow(2, 18);
// works as expected
console.assert(258048 === hash2, "Modulus 'hash2' should be != 0");
```

Truncating the passed in argument to a maximum of 16 characters solves the issue.

As a sidenote, the same code in Python will work correctly:

```python
key = '841b625dcf75413ff3ed5137a81ff1c3'
int = int(key, 16)
hash = int % pow(2, 18)
assert 258499 == hash
```
 2017-08-06 17:06:20 +02:00
Martin Zimmermann
c3933bd9fd fix sphinx build 2017-07-30 23:28:51 +02:00
Martin Zimmermann
c72946dc14 Run travis tests with python 3.5 & python 3.6 2017-07-30 22:38:12 +02:00
Martin Zimmermann
4c03a43c28 remove data-isso-id from documentation, it usually doesn't work as expected 2017-07-30 22:34:45 +02:00
Martin Zimmermann
e3a8d0b93d fix db test with incorrect SQL id, that happened work with pre-3.6 dicts before 2017-07-30 22:22:52 +02:00
Jelmer Vernooij
dc883e672a
Fix short title underline. 2017-07-29 15:21:33 +00:00
Jelmer Vernooij
539e6e4486 Merge pull request #336 from jelmer/flakes 
Fix pyflakes errors & run pyflakes on travis.
 2017-07-29 13:17:16 +00:00
Jelmer Vernooij
280b0d925a
Skip compat module when running flakes checks. 
Python2-specific code fails on Python3 flakes and vice versa.
 2017-07-29 13:09:48 +00:00
Jelmer Vernooij
39debdb011
Fix flakes errors. 2017-07-29 13:06:40 +00:00
Jelmer Vernooij
59b345b648
Run pyflakes on travis. 2017-07-29 13:04:54 +00:00
Jelmer Vernooij
8c33a84dd3 Merge pull request #253 from jGleitz/apidoc 
Update API documentation.
 2017-07-23 21:46:43 +00:00
Jelmer Vernooij
b8adfe3f18 Merge pull request #316 from shengbinmeng/patch-1 
Better configure options for Chinese language
 2017-07-21 14:21:48 +00:00
Shengbin Meng
2f7d6aa09b Merge branch 'master' into patch-1 2017-07-21 11:44:26 +08:00
Jelmer Vernooij
71bda25568 Merge pull request #312 from pellenilsson/fix-require-email 
Fix require-email setting
 2017-07-17 21:03:56 +00:00
Jelmer Vernooij
c8e4e74514 Merge pull request #335 from philipcmonk/time 
Display only complete units of time
 2017-07-17 20:51:47 +00:00
Jelmer Vernooij
afbcb6413e
Add da entry to i18n.js. 2017-07-17 20:49:56 +00:00
Jelmer Vernooij
6006cd9e82
Merge Danish translation from https://github.com/MadsRC/isso 2017-07-17 20:47:58 +00:00
Philip Monk
26f0e06e78 display only complete units of time 
fixes #283
 2017-07-15 18:20:02 -07:00
Jelmer Vernooij
616c61ea88 Merge pull request #291 from ivegotasthma/ivegotasthma-patch-1 
fix: add missing i18n entry
 2017-07-15 16:45:53 +00:00
Jelmer Vernooij
a23317818f Merge pull request #315 from ginggs/patch-1 
add SOURCELINK_SUFFIX for compatibility with Sphinx 1.5
 2017-07-15 16:40:55 +00:00
Jelmer Vernooij
384673ebdb
Run travis tests with python 3.5 & python 3.6. 2017-07-15 14:04:16 +00:00
Jelmer Vernooij
7bfe36bfdf
Specify Python versions to use in travis. 
This should address python2.6 being missing in the default environment. Fixes #332
 2017-07-15 13:11:23 +00:00
Jelmer Vernooij
2f3cd0ac46 Merge pull request #325 from SilverRainZ/patch-1 
Fix typo in isso.conf
 2017-07-15 13:07:18 +00:00
Jelmer Vernooij
fe4a1a11e9 Merge pull request #298 from kAworu/patch-2 
api.rst: JSON and english typos
 2017-07-15 11:54:23 +00:00
谷月轩
fd0147e8ab Fixed typo in isso.conf 2017-06-11 00:05:34 +08:00
Shengbin Meng
a9500e29dd Add language "zh" as alias of "zh_CN" 2017-03-28 21:56:07 +08:00
Shengbin Meng
4b7a32afac Make the Chinese translations actually work 
Before this change, the user must configure `lang="zh"` to use the CN version (neither `lang="zh_CN"` nor `lang="zh_TW"` works).
 2017-03-28 21:35:51 +08:00
Graham Inggs
88aafa60e5 add SOURCELINK_SUFFIX for compatibility with Sphinx 1.5 
With Sphinx 1.5, this is needed by searchtools.js to display the source
snippets (see sphinx-doc/sphinx#2454).

With earlier Sphinx versions, this is a no-op because the undefined variable
will evaluate to an empty string.
 2017-03-27 17:44:02 +02:00
Pelle Nilsson
45a481daeb Fix require-email setting, #308 2017-03-19 18:42:03 +01:00
Martin Zimmermann
d37b5bb030 Merge pull request #303 from MorrisJobke/highlight-links-in-text 
Highlight links by underline in comments
 2017-02-08 09:46:14 +01:00
Morris Jobke
f33ca31320
Highlight links by underline in comments 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-02-02 11:35:38 -06:00
Mads R. Havmand
cd460ef152 Danish translation 2017-01-07 19:02:00 +01:00
Alexandre Perrin
03b0de2d81 api.rst: JSON and english typos 2017-01-06 15:01:58 +01:00
Martin Zimmermann
e853442468 Merge pull request #295 from kAworu/patch-1 
default isso.conf typo
 2017-01-02 23:09:31 +01:00
Alexandre Perrin
3d67f10c72 default isso.conf typo 2017-01-02 23:05:01 +01:00
Martin Zimmermann
f3b1d0ba07 Merge pull request #293 from ckoepp/master 
added FreeBSD rc.d script
 2016-12-29 17:54:05 +01:00
Christian Koepp
45316e535a added FreeBSD rc.d script 2016-12-29 17:07:45 +01:00
ivegotasthma
09b69feae9 fix: add missing i18n entry 
Fixes an indexing error a user gets when he tries to make the language of isso to `bg`
 2016-12-17 22:42:07 +01:00
Martin Zimmermann
750bcd4829 Merge commit 'f9a36c8' 2016-10-12 09:34:23 +02:00
Martin Zimmermann
6e56afdd02 Merge branch 'pr/281' 2016-10-12 09:33:13 +02:00
Martin Zimmermann
5e7f010241 add persian to i18n 2016-10-12 09:32:59 +02:00
Philip Monk
f9a36c8b92 update doc to reflect 5ce48de 2016-10-11 10:42:11 -07:00
Aidin Gharibnavaz
5bd7de084f Adding Persian translation. 2016-10-07 19:56:19 +03:30
Martin Zimmermann
a361ee3980 Back to development: 0.10.7 2016-09-22 09:16:22 +02:00
Martin Zimmermann
ed6542c764 Preparing release 0.10.6 2016-09-22 09:16:04 +02:00
Martin Zimmermann
339318eb92 set require-author to false by default 2016-09-22 09:15:26 +02:00
Martin Zimmermann
80c1faeb82 Back to development: 0.10.6 2016-09-20 22:25:27 +02:00