arno/trezor-wallet
1
0
Fork 0
mirror of https://github.com/trezor/trezor-wallet synced 2024-11-28 03:08:30 +00:00
Code Issues Releases Wiki Activity

Fixed bug in function, add more tests

Browse Source
This commit is contained in:
Vladimir Volek 2018-10-02 20:06:59 +02:00 committed by Szymon Lesisz
parent 9771b21093
commit 802e8f8e32
3 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/reducers/utils/__tests__/__snapshots__/index.test.js.snap
View File

@ -18,6 +18,8 @@ exports[`reducers utils observeChanges shoud be the same - returns false 8`] = `
exports[`reducers utils observeChanges shoud be the same - returns false 9`] = `false`; exports[`reducers utils observeChanges shoud be the same - returns false 9`] = `false`;
exports[`reducers utils observeChanges shoud be the same - returns false 10`] = `false`;
exports[`reducers utils observeChanges shoul NOT be the same - returns true 1`] = `true`; exports[`reducers utils observeChanges shoul NOT be the same - returns true 1`] = `true`;
exports[`reducers utils observeChanges shoul NOT be the same - returns true 2`] = `true`; exports[`reducers utils observeChanges shoul NOT be the same - returns true 2`] = `true`;
@ -35,3 +37,5 @@ exports[`reducers utils observeChanges shoul NOT be the same - returns true 7`]
exports[`reducers utils observeChanges shoul NOT be the same - returns true 8`] = `true`; exports[`reducers utils observeChanges shoul NOT be the same - returns true 8`] = `true`;
exports[`reducers utils observeChanges shoul NOT be the same - returns true 9`] = `true`; exports[`reducers utils observeChanges shoul NOT be the same - returns true 9`] = `true`;
exports[`reducers utils observeChanges shoul NOT be the same - returns true 10`] = `true`;

10
src/reducers/utils/__tests__/index.test.js
View File

@ -16,6 +16,10 @@ describe('reducers utils', () => {
pervious: [], pervious: [],
current: [], current: [],
}, },
{
pervious: [1, 1, 1],
current: [1, 1, 1],
},
{ {
pervious: 'a', pervious: 'a',
current: 'a', current: 'a',
@ -57,9 +61,13 @@ describe('reducers utils', () => {
current: {}, current: {},
}, },
{ {
pervious: [{}], pervious: [{}, {}],
current: [], current: [],
}, },
{
pervious: [1, 1, 1],
current: [1, 1],
},
{ {
pervious: 'a', pervious: 'a',
current: 'b', current: 'b',

2
src/reducers/utils/index.js
View File

@ -122,7 +122,7 @@ export const observeChanges = (prev: ?Object, current: ?Object, filter?: {[k: st
// 2. one of the objects is null/undefined // 2. one of the objects is null/undefined
if (!prev || !current) return true; if (!prev || !current) return true;
const prevType = Object.prototype.toString.call(current); const prevType = Object.prototype.toString.call(prev);
const currentType = Object.prototype.toString.call(current); const currentType = Object.prototype.toString.call(current);
// 3. one of the objects has different type then other // 3. one of the objects has different type then other
if (prevType !== currentType) return true; if (prevType !== currentType) return true;