From 25548debd07c3eb5fea1d8f2244b0931c9cc1b5c Mon Sep 17 00:00:00 2001 From: slowbackspace Date: Fri, 17 May 2019 17:17:46 +0200 Subject: [PATCH] comment about potential incorrect balance with contracts --- src/actions/ethereum/BlockchainActions.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/actions/ethereum/BlockchainActions.js b/src/actions/ethereum/BlockchainActions.js index ce61a1d4..928f1474 100644 --- a/src/actions/ethereum/BlockchainActions.js +++ b/src/actions/ethereum/BlockchainActions.js @@ -141,6 +141,9 @@ export const onBlockMined = (network: string): PromiseAction => async ( dispatch(Web3Actions.updateAccount(accounts[i], a, network)); } else { // there are no new txs, just update block + // TODO: There still could be internal transactions as a result of contract + // If that's the case, account balance won't be updated + // Currently waiting for deprecating web3 and utilising new blockbook dispatch(AccountsActions.update({ ...accounts[i], block: a.block })); // HACK: since blockbook can't work with smart contracts for now