From f71af4387433550743a48bd17bce2a2a1a2439e7 Mon Sep 17 00:00:00 2001 From: Andrew Kozlik Date: Wed, 14 Oct 2020 15:54:58 +0200 Subject: [PATCH] chore(common): Add sanity checks for protobuf definitions. --- common/protob/pb2py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/common/protob/pb2py b/common/protob/pb2py index 2b457ec98..854aea834 100755 --- a/common/protob/pb2py +++ b/common/protob/pb2py @@ -306,10 +306,20 @@ class Descriptor: comment = "" if field.repeated: + if field.default_value is not None: + raise ValueError("Repeated fields can't have default values.") + if field.experimental: + raise ValueError("Repeated experimental fields are currently not supported.") flags = "p.FLAG_REPEATED" elif field.required: + if field.default_value is not None: + raise ValueError("Required fields can't have default values.") + if field.experimental: + raise ValueError("Required fields can't be experimental.") flags = "p.FLAG_REQUIRED" elif field.experimental: + if field.default_value is not None: + raise ValueError("Experimental fields can't have default values.") flags = "p.FLAG_EXPERIMENTAL" else: flags = field.default_value