From 54199e43aea6bc2f48356380f7319ac9216c3bae Mon Sep 17 00:00:00 2001
From: Martin Milata <martin@martinmilata.cz>
Date: Thu, 14 Mar 2024 22:09:04 +0100
Subject: [PATCH] ci: actions: primitive icons for UI diff comments

[skip_ci]
---
 .github/actions/ui-report/action.yml  |  10 ++++++++++
 .github/actions/ui-report/failure.png | Bin 0 -> 1322 bytes
 .github/actions/ui-report/success.png | Bin 0 -> 1467 bytes
 .github/workflows/core.yml            |  19 ++++++++++++++-----
 .github/workflows/legacy.yml          |  11 +++++++++--
 5 files changed, 33 insertions(+), 7 deletions(-)
 create mode 100644 .github/actions/ui-report/failure.png
 create mode 100644 .github/actions/ui-report/success.png

diff --git a/.github/actions/ui-report/action.yml b/.github/actions/ui-report/action.yml
index c916d0fa6..1f2a7074a 100644
--- a/.github/actions/ui-report/action.yml
+++ b/.github/actions/ui-report/action.yml
@@ -4,6 +4,10 @@ inputs:
   model:
     description: 'Internal model name'
     required: true
+  status:
+    description: 'Either "success" or "failure"'
+    required: false
+    default: "failure"
 runs:
   using: composite
   steps:
@@ -22,6 +26,12 @@ runs:
         mv tests/trezor.log $OUTDIR || true
         diff -u tests/ui_tests/fixtures.json tests/ui_tests/fixtures.suggestion.json || true
         tar -cf screens_$MODELJOB.tar tests/ui_tests/screens || true
+
+        if [ "${{ inputs.status }}" = "success" ]; then
+          cp .github/actions/ui-report/success.png $OUTDIR/status.png
+        else
+          cp .github/actions/ui-report/failure.png $OUTDIR/status.png
+        fi
       shell: sh
     - name: Upload report
       run: |
diff --git a/.github/actions/ui-report/failure.png b/.github/actions/ui-report/failure.png
new file mode 100644
index 0000000000000000000000000000000000000000..f65202a83bd12d358107d49eb70a82890faf3ec8
GIT binary patch
literal 1322
zcmZvaeN5I>6vxl=0I4YO2fi#Zar%Q%D;w(pG#>=nLvW@cHG<G4ER|U9z?67~=8y!z
z7pigAe8FM_3Z_#c;w*I2tYJkIh%|&7mNj#v8}pB+*+g#l!Oa0rzwO?8?r-<p&-Z-K
zJ&>N35)`;F5CDQO)%B`b=X%FXyP55G4sHPOgY<P7$!4o3hMrio*=g^mloAnUCL%<%
zEK30h00R&J0$3)?=a*6-0?a@Jh+zHSAq7f67?^+%&@wmqr1|2th+-BZMkLG9%!)`5
z*~CN&QA~iS%xt7;B}!PBn2^vyOSG_J5<*6cEY?hlP|#wFG@&vlEYxUC<SR9eh9Z-J
z#Qd0P{CR{mTD)Y#_cc#zQHn)OA`+PstQ3hLvx!M5bH52tDKlHzN4*xUSP2OulhMms
zkrEU(b&yu5#MFmcnYz8%Q(?xL$vk7=W29;BBdU>Nz!P{M=U}RHW;?kQZ<95PA{HdJ
zkib&Yyapq5lHEX}rez?DCRRwM2MiWXE!X=-SPLmeF`YvoQ|HvzfH1W`MkFW(Auz`^
zhyoTMHqTZxurd<BfF{14XYBp}wp-|0ld<B*vmdP~7)qR5spGOc{qGKDo=!i1peks~
z=EAi%?IQvF&(f8y<+;1|E~>Ant9Qp<AI><~@1ETa?`Jq$X0Q5SZ6ckx_=)FIp`&!P
z?cTQCl+@w8Gx+RZdrs|M*mA>tr2NmHzT37TC}%J{=W<2UyDMrJ-H*Tf{PD;$hgKik
z7qNd?R{byjp)a)6Y3HbN45sXGUnteJ-S)EF-?xSxcf`IIm({!a%aEr^{&n2gxiPe>
z;jMGI_MW`xqk~O2FTcIKr@1xQd3N#l=>>g9kG*mw`-iaPp{iM1>mpV)Cf_e{L>I+W
zdoINF7QvjR!|yaimw7tNJk^OSUw6be$M&au^~cWWWj0xoWj~d$_@y{c@tDo;^PGZ#
z+YbXFz2@iqrD^9qd9Cds+xv<eqC5CWm&?_?B<sbiC5L{sC7c=mt(|K7aYsZ4KbKmz
zpsjg4e)DVH)rSZ6M<#i`23v8}x*7ZCtdDs5)=1)vO?9R6@sY}T_ujZ1)fe;N^w5dc
zStm!F4*yNt9bJhvnJ2Gr+|s#VS6FyJ;kAm)a`*VdVE@S8n%mU{!DH8k!;9u;jfT8g
zdUd}0vur5K@48a8{y{2ylR&P}w=wUD(2K)2$N%n&>igCm^Xa9r$}e0YAHEzl+Om9)
XUqE9}`@qccMsMdaIn8x0DR=LGWWQ{u

literal 0
HcmV?d00001

diff --git a/.github/actions/ui-report/success.png b/.github/actions/ui-report/success.png
new file mode 100644
index 0000000000000000000000000000000000000000..7513721c2c028fa35d7ef35385990fc5ea34af9d
GIT binary patch
literal 1467
zcmZuw4NTQl6u%GA9yUJ3L50EWG6?xl_7q4*z#zEd5DaZdOOucUZb-!o1_mLpL|(uF
z8WCs%nwWrOa2XkidqmA=@xsBBTgrzBVj@#QNb+_cZjO)ccJDpszjN;IcYf#mkA;T?
zo34I-HA2Xggaq!Ax3ys_jpS)`Cx0(OD^U23$RO#8`7P!zAw6MOoO8w)08mN^AsAzh
z5JLzMq6iU$u*_QaiF3pl0zi}^LJ<DHAdWag3=mL62_jg&v@C5oykLw2FiL?Cim?FT
zlrlm<+LUram^29C@|08sXPf~83Y1WS31)%;2g)b`f++?8lvBb8222GdTt;9b2%gX9
zd<hz1Y#|^8c#0|Yc>*iB7?36Ya`A*<oC9Mrkx(ilfOE<i0gyK3T)r<2!nr)LSjJv3
z!GSZ%fB=<zL2$|$VIb?Ef)mbUeME3sw;_8mm{evVo)qvYq-^dJR7phw&%-ZM4lPzr
zx(iD&G+6-S6d0j^2}PJM(Hcpj3*<(W@g*4qn4rK3l|2B2>Edz?GXjE94ur|h5kzI3
zi>HC0#r=^a5eLL5lHmd|j({Nwa%`DEz$FDFf#z4Yi;=PXBh)0&Khj%QRuZ~nO@wt`
zcYD?CsS*99aEpzW<dgfQrV1M<%F}%AFqWNrPOr?as5`dRCVt3F({EAsF2)BERmMXr
zHsQvOeE%2S3gh(-mM(<~?s?_6%PA3#n)~C|u4nj&Ss~U3C_B9sWa_woiTatf8`_*_
z&YJrsRj6BT+52yzd$O7femrfT`c7?BM0XcUn;ea7KYyj}vth@<z7svR10(wJvcfRs
z@of<<CC|p6GaI<8HSfBic1wLO$G_oxW!z4EQ?%AH^q+%H>xSD^4#he5V)=t#Z=<G`
zMB{-qdnO8gD7Q*Ob>!07=F)Iw@!bxqBD17@kN()GIUU)5c+11DqO?}XI7{JoP1P{i
z=8<y3ebw)8JH&bFwyR?UZz449`tb$TWan&~hjZ>@C!0XgTO6ib8B~3B*v+Y)jlEHJ
z%JtiSdHQJchP4R~tfqI_21ob4(wDB~F|{hApjWSFdTKTYYs+g=kj2hBFXWx{wM%nz
z>8a4VpKQJOXKd|M#??%(Q`P#)=|cC6hNk|mSoe_Zh_4guj;J%o%Ibbm?tg2_>&UpV
zPiN@G{?h7irmW^hdz`&>rGGj5zBlZd8l{i<+vlTToj%mRxN7)brEhC~QPuY|ultOc
z>{VA;zhobic<5F}X7t0koK<HW3(TFOE;P>g&Q+`ow`<$2d1ThGPZ1D;Roy+8b04#b
zS(BsrCeEHmoBVFp98CD&(7K;(`*M@9$_Vq)_rIGd*XSm7>(5k2DiuGy=~_2nt9@;A
zN9NW~m07)|L(YvY$zSLOd;PrimDFQ<bN%iE+AnM3KqRNv$F**m_%O^TG{NiT8%c^F
Vak#i<TcTkUNl;i|W5E9G{{V@eywU&w

literal 0
HcmV?d00001

diff --git a/.github/workflows/core.yml b/.github/workflows/core.yml
index 09fc0cdc3..3f030c637 100644
--- a/.github/workflows/core.yml
+++ b/.github/workflows/core.yml
@@ -20,10 +20,10 @@ env:
   PULL_COMMENT: |
     |core UI changes|device test|click test|persistence test|
     |---------------|-----------|----------|----------------|
-    |T2T1 Model T   |[test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/master_diff.html)) |[test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/master_diff.html)) |[test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/master_diff.html))||
-    |T2B1 Safe 3    |[#3280](https://github.com/trezor/trezor-firmware/issues/3280)                                                                                                                                                                                                                                                                                                                                                                                                                   |[test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/master_diff.html)) |[#2724](https://github.com/trezor/trezor-firmware/issues/2724)                                                                                                                                                                                                                                                                                                                                                                                                                                      ||
-    |T3T1           |[test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/master_diff.html)) |[test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/master_diff.html)) |[test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/master_diff.html))||
-    |All            |[main](https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/index.html)([screens](https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/master_diff.html)) ||
+    |T2T1 Model T   |<img src="https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/status.png" width="24" height="20px" /> [test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_device_test/master_diff.html)) |<img src="https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/status.png" width="20px" height="20px" /> [test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_click_test/master_diff.html)) |<img src="https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/status.png" width="20px" height="20px" /> [test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2T1-core_persistence_test/master_diff.html))||
+    |T2B1 Safe 3    |[3280](https://github.com/trezor/trezor-firmware/issues/3280)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |<img src="https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/status.png" width="20px" height="20px" /> [test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T2B1-core_click_test/master_diff.html)) |[2724](https://github.com/trezor/trezor-firmware/issues/2724)                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    ||
+    |T3T1           |<img src="https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/status.png" width="20px" height="20px" /> [test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_device_test/master_diff.html)) |<img src="https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/status.png" width="20px" height="20px" /> [test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_click_test/master_diff.html)) |<img src="https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/status.png" width="20px" height="20px" /> [test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/master_index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T3T1-core_persistence_test/master_diff.html))||
+    |All            |<img src="https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/status.png" width="20px" height="20px" /> [main](https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/index.html)([screens](https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/master_diff.html)) ||
 
 jobs:
   param:
@@ -251,6 +251,7 @@ jobs:
       - uses: ./.github/actions/ui-report
         with:
           model: ${{ matrix.model }}
+          status: ${{ job.status }}
         if: ${{ always() && env.ACTIONS_DO_UI_TEST == 'true' }}
         continue-on-error: true
       - uses: ./.github/actions/ui-comment
@@ -304,6 +305,7 @@ jobs:
       - uses: ./.github/actions/ui-report
         with:
           model: ${{ matrix.model }}
+          status: ${{ job.status }}
         if: always()
         continue-on-error: true
       - run: mv core/src/.coverage core/.coverage.test_click || true
@@ -377,6 +379,7 @@ jobs:
       - uses: ./.github/actions/ui-report
         with:
           model: ${{ matrix.model }}
+          status: ${{ job.status }}
         if: always()
         continue-on-error: true
       - run: mv core/src/.coverage core/.coverage.test_persistence || true
@@ -679,7 +682,13 @@ jobs:
         continue-on-error: true
       - run: "for F in screens_*.tar; do tar xvf $F; done || true"
       - run: nix-shell --run "poetry run python -m tests.ui_tests.reporting master-diff TT TR"
-      - run: mv tests/ui_tests/reports/master_diff .
+      - run: |
+          mv tests/ui_tests/reports/master_diff .
+          if [ "${{ job.status }}" = "success" ]; then
+            cp .github/actions/ui-report/success.png master_diff/status.png
+          else
+            cp .github/actions/ui-report/failure.png master_diff/status.png
+          fi
       - name: Upload diff from main branch
         run: |
           aws s3 sync master_diff s3://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}
diff --git a/.github/workflows/legacy.yml b/.github/workflows/legacy.yml
index d836e862b..e6c40aeab 100644
--- a/.github/workflows/legacy.yml
+++ b/.github/workflows/legacy.yml
@@ -11,7 +11,7 @@ permissions:
 
 env:
   PULL_COMMENT: |
-    |legacy UI changes|[device test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T1B1-legacy_device_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T1B1-legacy_device_test/differing_screens.html)) [main](https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/)([screens](https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/master_diff.html))|
+    |legacy UI changes|<img src="https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T1B1-legacy_device_test/status.png" width="20px" height="20px" /> [device test](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T1B1-legacy_device_test/index.html)([screens](https://data.trezor.io/dev/firmware/ui_report/${{ github.run_id }}/T1B1-legacy_device_test/differing_screens.html)) <img src="https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/status.png" width="20px" height="20px" /> [main](https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/)([screens](https://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}/master_diff.html))|
     |-----------------|-----|
 
 jobs:
@@ -97,6 +97,7 @@ jobs:
       - uses: ./.github/actions/ui-report
         with:
           model: T1B1
+          status: ${{ job.status }}
         continue-on-error: true
         if: ${{ always() && matrix.coins == 'universal' }}
       - uses: ./.github/actions/ui-comment
@@ -167,7 +168,13 @@ jobs:
         continue-on-error: true
       - run: "for F in screens_*.tar; do tar xvf $F; done || true"
       - run: nix-shell --run "poetry run python -m tests.ui_tests.reporting master-diff T1"
-      - run: mv tests/ui_tests/reports/master_diff .
+      - run: |
+          mv tests/ui_tests/reports/master_diff .
+          if [ "${{ job.status }}" = "success" ]; then
+            cp .github/actions/ui-report/success.png master_diff/status.png
+          else
+            cp .github/actions/ui-report/failure.png master_diff/status.png
+          fi
       - name: Upload main branch diff
         run: |
           aws s3 sync master_diff s3://data.trezor.io/dev/firmware/master_diff/${{ github.run_id }}