From 0ca440339a1fceea66e053399615c3aa3d14760e Mon Sep 17 00:00:00 2001
From: grdddj <jiri.musil06@seznam.cz>
Date: Wed, 9 Aug 2023 13:20:43 +0200
Subject: [PATCH] feat(tests): notify about failed tests when updating fixtures
 from CI

[no changelog]
---
 tests/gitlab.py          | 38 ++++++++++++++++++++++++++++++++++++++
 tests/update_fixtures.py |  5 +++++
 2 files changed, 43 insertions(+)

diff --git a/tests/gitlab.py b/tests/gitlab.py
index ff1e5bc70..b7719bf38 100644
--- a/tests/gitlab.py
+++ b/tests/gitlab.py
@@ -7,6 +7,8 @@ Allowing for interaction with the test results, e.g. with UI tests.
 from __future__ import annotations
 
 import json
+import re
+from dataclasses import dataclass
 from pathlib import Path
 from typing import Any, Iterable, Iterator
 
@@ -18,6 +20,9 @@ HERE = Path(__file__).parent
 
 BRANCHES_API_TEMPLATE = "https://gitlab.com/satoshilabs/trezor/trezor-firmware/-/pipelines.json?scope=branches&page={}"
 GRAPHQL_API = "https://gitlab.com/api/graphql"
+RAW_REPORT_URL_TEMPLATE = (
+    "https://gitlab.com/satoshilabs/trezor/trezor-firmware/-/jobs/{}/raw"
+)
 
 UI_JOB_NAMES = (
     "core click R test",
@@ -31,6 +36,33 @@ UI_JOB_NAMES = (
 SAVE_GRAPHQL_RESULTS = False
 
 
+@dataclass
+class TestResult:
+    failed: int = 0
+    passed: int = 0
+    error: int = 0
+
+    @classmethod
+    def from_line(cls, line: str) -> TestResult:
+        self = TestResult()
+        for key in self.__annotations__:
+            match = re.search(rf"(\d+) {key}", line)
+            if match:
+                setattr(self, key, int(match.group(1)))
+        return self
+
+    @classmethod
+    def from_job_id(cls, job_id: str) -> TestResult:
+        report_link = RAW_REPORT_URL_TEMPLATE.format(job_id)
+        raw_content = requests.get(report_link).text
+        result_pattern = r"= .* passed.*s \(\d.*\) ="
+        result_line_match = re.search(result_pattern, raw_content)
+        if not result_line_match:
+            print("No results yet.")
+            return TestResult()
+        return cls.from_line(result_line_match.group(0))
+
+
 def _get_gitlab_branches(page: int) -> list[AnyDict]:
     return requests.get(BRANCHES_API_TEMPLATE.format(page)).json()["pipelines"]
 
@@ -96,6 +128,12 @@ def _yield_pipeline_jobs(pipeline_iid: int) -> Iterator[AnyDict]:
 def _get_job_ui_fixtures_results(job: AnyDict) -> AnyDict:
     print(f"Checking job {job['name']}")
     job_id = job["id"].split("/")[-1]
+
+    job_results = TestResult.from_job_id(job_id)
+    if job_results.failed:
+        print(f"ERROR: Job {job['name']} failed - {job_results}")
+        return {}
+
     url = f"https://satoshilabs.gitlab.io/-/trezor/trezor-firmware/-/jobs/{job_id}/artifacts/tests/ui_tests/fixtures.results.json"
     response = requests.get(url)
     if response.status_code != 200:
diff --git a/tests/update_fixtures.py b/tests/update_fixtures.py
index 928337325..335eb56c5 100755
--- a/tests/update_fixtures.py
+++ b/tests/update_fixtures.py
@@ -76,10 +76,12 @@ def ci(
 
     current_fixtures = get_current_fixtures()
 
+    is_error = False
     differing_total = 0
     for job_name, ui_res_dict in ui_results.items():
         print(f"Updating results from {job_name}...")
         if not ui_res_dict:
+            is_error = True
             print("No results found.")
             continue
         model = next(iter(ui_res_dict.keys()))
@@ -103,6 +105,9 @@ def ci(
         json.dumps(current_fixtures, indent=0, sort_keys=True) + "\n"
     )
     print("Updated fixtures.json with data from CI.")
+    if is_error:
+        print(80 * "-")
+        raise click.ClickException("Some jobs did not have any results.")
 
 
 if __name__ == "__main__":