arno/privatebin
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make link clickable again

Browse Source 
We need to emulate the click and manually trigger a reload if the hash is
already shown in the URL.
This commit is contained in:
rugk 2017-02-05 21:22:09 +01:00
parent 366b61c32d
commit c96dd0836b
No known key found for this signature in database
GPG Key ID: 05D40A636AFAB34D
4 changed files with 38 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
js/privatebin.js
View File

@ -1121,6 +1121,7 @@ jQuery.PrivateBin = function($, sjcl, Base64, RawDeflate) {
deleteUrl = helper.scriptLocation() + '?pasteid=' + data.id + '&deletetoken=' + data.deletetoken;
controller.showStatus('');
controller.errorMessage.addClass('hidden');
// show new URL in browser bar
history.pushState({type: 'newpaste'}, document.title, url);
$('#pastelink').html(
@ -1129,6 +1130,11 @@ jQuery.PrivateBin = function($, sjcl, Base64, RawDeflate) {
url, url
) + controller.shortenUrl(url)
);
// save newly created element
controller.pasteUrl = $('#pasteurl');
// and add click event
controller.pasteUrl.click($.proxy(controller.pasteLinkClick, controller));
var shortenButton = $('#shortenbutton');
if (shortenButton) {
shortenButton.click($.proxy(controller.sendToShortener, controller));
@ -1489,6 +1495,25 @@ jQuery.PrivateBin = function($, sjcl, Base64, RawDeflate) {
}
},
/**
* Forces opening the paste if the link does not do this automatically.
*
* This is necessary as browsers will not reload the page when it is
* already loaded (which is fake as it is set via history.pushState()).
*
* @name controller.pasteLinkClick
* @function
* @param {Event} event
*/
pasteLinkClick: function(event)
{
// check if location is (already) correctly shown in URL bar
if (window.location.href === this.pasteUrl.attr('href')) {
// if so we need to load link by reloading the site
location.reload(true);
}
},
/**
* create a new paste
*
@ -1689,6 +1714,8 @@ jQuery.PrivateBin = function($, sjcl, Base64, RawDeflate) {
this.passwordForm = $('#passwordform');
this.passwordDecrypt = $('#passworddecrypt');
this.pasteResult = $('#pasteresult');
// this.pasteUrl is saved in sendDataContinue() if/after it is
// actually created
this.prettyMessage = $('#prettymessage');
this.prettyPrint = $('#prettyprint');
this.preview = $('#preview');

19
js/test.js
View File

@ -91,14 +91,14 @@ describe('helper', function () {
jsc.array(jsc.elements(queryString)),
'string',
function (schema, address, query, fragment) {
var query = query.join(''),
var queryString = query.join(''),
clean = jsdom('', {
url: schema.join('') + '://' + address.join('') +
'/?' + query + '#' + fragment
'/?' + queryString + '#' + fragment
}),
result = $.PrivateBin.helper.pasteId();
clean();
return query === result;
return queryString === result;
}
);
});
@ -111,14 +111,14 @@ describe('helper', function () {
jsc.array(jsc.elements(queryString)),
jsc.array(jsc.elements(base64String)),
function (schema, address, query, fragment) {
var fragment = fragment.join(''),
var fragmentString = fragment.join(''),
clean = jsdom('', {
url: schema.join('') + '://' + address.join('') +
'/?' + query.join('') + '#' + fragment
'/?' + query.join('') + '#' + fragmentString
}),
result = $.PrivateBin.helper.pageKey();
clean();
return fragment === result;
return fragmentString === result;
}
);
jsc.property(
@ -129,14 +129,14 @@ describe('helper', function () {
jsc.array(jsc.elements(base64String)),
jsc.array(jsc.elements(queryString)),
function (schema, address, query, fragment, trail) {
var fragment = fragment.join(''),
var fragmentString = fragment.join(''),
clean = jsdom('', {
url: schema.join('') + '://' + address.join('') + '/?' +
query.join('') + '#' + fragment + '&' + trail.join('')
query.join('') + '#' + fragmentString + '&' + trail.join('')
}),
result = $.PrivateBin.helper.pageKey();
clean();
return fragment === result;
return fragmentString === result;
}
);
});
@ -156,4 +156,3 @@ describe('helper', function () {
);
});
});

2
tpl/bootstrap.php
View File

@ -69,7 +69,7 @@ if ($MARKDOWN):
<?php
endif;
?>
<script type="text/javascript" src="js/privatebin.js?<?php echo rawurlencode($VERSION); ?>" integrity="sha512-bOZxf+ELU4lyYdlSIVM0z+GDBdeO1BZQvkr7HKPz89rmnw6x7w669QOsCOqLoNJ8vcIsFas288doubME9pSE4Q==" crossorigin="anonymous"></script>
<script type="text/javascript" src="js/privatebin.js?<?php echo rawurlencode($VERSION); ?>" integrity="sha512-K+5hyQ7JbqWRHoidP56Ox7nIqgGrD9SRfSMv1L0gJDzXhDeYhwwj5F0/FXcEfoFMcTiJGLkFTLmuDxhsjksywA==" crossorigin="anonymous"></script>
<!--[if lt IE 10]>
<style type="text/css">body {padding-left:60px;padding-right:60px;} #ienotice {display:block;} #oldienotice {display:block;}</style>
<![endif]-->

2
tpl/page.php
View File

@ -47,7 +47,7 @@ if ($MARKDOWN):
<?php
endif;
?>
<script type="text/javascript" src="js/privatebin.js?<?php echo rawurlencode($VERSION); ?>" integrity="sha512-bOZxf+ELU4lyYdlSIVM0z+GDBdeO1BZQvkr7HKPz89rmnw6x7w669QOsCOqLoNJ8vcIsFas288doubME9pSE4Q==" crossorigin="anonymous"></script>
<script type="text/javascript" src="js/privatebin.js?<?php echo rawurlencode($VERSION); ?>" integrity="sha512-K+5hyQ7JbqWRHoidP56Ox7nIqgGrD9SRfSMv1L0gJDzXhDeYhwwj5F0/FXcEfoFMcTiJGLkFTLmuDxhsjksywA==" crossorigin="anonymous"></script>
<!--[if lt IE 10]>
<style type="text/css">body {padding-left:60px;padding-right:60px;} #ienotice {display:block;} #oldienotice {display:block;}</style>
<![endif]-->