mirror of https://github.com/pi-hole/pi-hole
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
dependabot/pip/test/development/pytest-8.2.2
development-v6
development
dependabot/pip/test/development/tox-4.15.1
tweak/docker_ftl_checkout
master
fix/checkout_versions
new/optimize
double_dig_v5
fix/query_all
tests_systemd
ftl-binary-names
checkout/tags
gravity-test
tweak/gravity
fix_FTLcheckUpdate
tests_systemd_new
v4.3.2
2.0
2.8
V2.5.1
V2.9.1
V2.9.2
v2.1
v2.10
v2.10.1
v2.10.2
v2.11
v2.11.1
v2.11.2
v2.12
v2.12.1
v2.13
v2.13.1
v2.13.2
v2.2
v2.3
v2.4
v2.5
v2.5.2
v2.5.3
v2.6
v2.6.1
v2.6.1.1
v2.6.1.2
v2.6.2
v2.6.3
v2.7
v2.7.1
v2.8.1
v2.9
v2.9-alpha
v2.9.3
v2.9.4
v2.9.4a
v2.9.5
v3.0
v3.0.1
v3.1
v3.1.4
v3.2
v3.2.1
v3.3
v3.3.1
v4.0
v4.1
v4.1.1
v4.2
v4.2.1
v4.2.2
v4.3
v4.3.1
v4.3.3
v4.3.4
v4.3.4int
v4.3.5
v4.4
v5.0
v5.1
v5.1.1
v5.1.2
v5.10
v5.11
v5.11.1
v5.11.2
v5.11.3
v5.11.4
v5.12
v5.12.1
v5.12.2
v5.13
v5.14
v5.14.1
v5.14.2
v5.15
v5.15.1
v5.15.2
v5.15.3
v5.15.4
v5.15.5
v5.16
v5.16.1
v5.16.2
v5.17
v5.17.1
v5.17.2
v5.17.3
v5.18
v5.18.1
v5.18.2
v5.2
v5.2.1
v5.2.2
v5.2.3
v5.2.4
v5.3
v5.3.1
v5.4
v5.5
v5.6
v5.7
v5.8
v5.8.1
v5.9
v5.9.1
${ noResults }
MichaIng
e1dca46423
With the suggested way to call the installer via "curl -sSL https://install.pi-hole.net | bash", STDIN is no terminal, but overridden by the curl output, hence in most cases, the minimum dimensions were applied, even on larger screens. All whiptail calls are hence assured to work fine with those dimensions, aside of one case, making the calculations obsolete. This commit hardcodes the whiptail dimensions to the prior minimum and removes the calculations. This also helps with testing, as it does not matter anymore how the script is called, and developers have a clearly defined space to make dialogs look nice, including line breaks, menu and list heights. The only case which does not fit the 70 character width, the second menu entry of the "pihole -r" dialog, has been shortened accordingly. This was not an issue before, as "pihole -r" does not override the scripts STDIN and hence did allow larger dimensions based on the now removed calculations. See the following discussions for reference: - https://github.com/pi-hole/pi-hole/issues/3323 - https://github.com/pi-hole/pi-hole/pull/4197#issuecomment-876702380 Signed-off-by: MichaIng <micha@dietpi.com> |
3 years ago | |
---|---|---|
.. | ||
basic-install.sh | Hardcode whiptail dimensions to 20 rows and 70 chars width | 3 years ago |
uninstall.sh | rename distro_check to package_manager_detect, as it is more in keeping with what the function actually does | 3 years ago |