Christian König
5c564e53ca
Fix indention in install script output
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Dan Schaper
853cd9670a
Merge pull request #4772 from pi-hole/tweak/dialog
...
Convert installer whiptail to dialog
2 years ago
Dan Schaper
cfbc731eab
Apply suggestions from code review
...
Co-authored-by: yubiuser <ckoenig@posteo.de>
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Dan Schaper
46f991f578
Apply suggestions from code review
...
Co-authored-by: yubiuser <ckoenig@posteo.de>
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
RD WebDesign
ad70ece73e
Fixing dialog line breaks
...
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2 years ago
Dan Schaper
39cb1029e9
Clarify button labels
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Dan Schaper
a39c470f2d
Requested changes.
...
Co-authored-by: MichaIng <micha@dietpi.com>
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Dan Schaper
72fcdb128a
Rework cenos7 functions
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Dan Schaper
44667b5ffb
Add dialog to RPM installer requirements.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
yubiuser
696d1c4ec3
Merge pull request #4777 from pi-hole/tweak/default_log_path
...
Change default FTL log file path to /var/log/pihole/FTL.log
2 years ago
Dan Schaper
1ed5ff306d
Align dialog texts.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Dan Schaper
bf57a786e6
Convert whiptail to dialog.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Dan Schaper
80bef5f6b6
Direct pull for epel-release
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
DL6ER
bd8288d6ef
Special renaming for pihole-FTL.* to pihole/FTL.log.*
...
Signed-off-by: DL6ER <dl6er@dl6er.de>
2 years ago
Adam Warner
0be987239e
Adds spellcheck action to the smoke-tests (also moves editorconfig-checker to smoketests away from it's own action)
...
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2 years ago
Christian König
ed8c6c04d4
Use PHP_VERSION
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
4b674ecfe3
Fix first install
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
5818f3f997
Check for validity first
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
7d731870e5
Fix stickler
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
1f26e85399
Exit installer if no valid PHP version is found
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
2c07d27ad7
Forgot two places
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
0b9d4a47ad
Remove IPv4 and IPv6 adresses from setupVars.conf
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
yubiuser
ae9d16baf2
Merge pull request #3732 from pi-hole/tweak/moveloglocation
...
Utilise /var/log/pihole/ for log storage
2 years ago
Christian König
b7742ddb9b
Always install pihole-FTL.service file
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
60615e60aa
Make sure FTL is stopped before old logfiles are moved
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
110e752552
Move existing log files
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
9b9acfd4a7
Remove log files from new location during uninstalling
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
yubiuser
2e2a3aa048
Add port info to explanation text
2 years ago
Leon
6a0c6c4a9b
Add example for custom DNS server with port number
...
Signed-off-by: sed-i <82407168+sed-i@users.noreply.github.com>
2 years ago
Adam Warner
73aa43611f
Merge pull request #4700 from spmfox/4697-centos8-container-ftl-arch
...
Changed ldd binary check for better compatibility
2 years ago
Dan Schaper
71072b4beb
Stickler quoting
2 years ago
spmfox
9840148ba9
Update automated install/basic-install.sh
...
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
spmfox
2601162243
Changed ldd binary check from /bin/ls to /usr/bin/bash
...
Signed-off-by: spmfox <spmfox@foxwd.com>
2 years ago
MichaIng
2b124b1c69
Do not pass whole environment for PIHOLE_SKIP_OS_CHECK=true
...
With `sudo -E`, the whole environment is passed to the root shell, which is a potential security and/or privacy issue when command overrides/functions, PATH or private user info are passed. To pass `PIHOLE_SKIP_OS_CHECK=true`, it can be passed alone to the bash/script call within the sudo session, so the `-E` flag can be omitted.
Signed-off-by: MichaIng <micha@dietpi.com>
2 years ago
yubiuser
9356d7bbb1
Remove unnecessary case in uninstall script ( #4692 )
...
* Remove unnecessary case in uninstall script
* Better answer
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
yubiuser
b33434d02a
Let uses know how long they need to wait (max)
...
Co-authored-by: Adam Warner <me@adamwarner.co.uk>
2 years ago
Christian König
c0a2ab7b77
Fix indention
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
30ba79f6a0
Let users know what's going on
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Christian König
cd3c97f113
Exit installer if dpkg lock is held for more then 30 seconds
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
Adam Warner
fe9031b26f
Merge pull request #4669 from pi-hole/master
...
sync: master to development
2 years ago
Dan Schaper
8a5c7dec71
Ensure existing files are proper owner and mode.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
2 years ago
Dan Schaper
d45c9fc522
Final touch to install fix.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Dan Schaper
c2384ecc6f
Change touch that would always fire to install.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Dan Schaper
2f38452565
Wrap touch calls with if/then guards for Buster docker.
...
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
2 years ago
Christian König
c756bcb9d1
Add procps to dependencies
...
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
yubiuser
c3c5342b48
Fix reviewer's comment
...
Co-authored-by: DL6ER <DL6ER@users.noreply.github.com>
2 years ago
Christian König
7c60ee8df1
Remove pihole-FTL.conf man page
...
Signed-off-by: Christian König <ckoenig@posteo.de>
Remove double https://
Signed-off-by: Christian König <ckoenig@posteo.de>
2 years ago
DL6ER
e09dd56807
Remove RPM package sqlite as well
...
Signed-off-by: DL6ER <dl6er@dl6er.de>
2 years ago
DL6ER
8cbffa179d
Replace remaining sqlite3 calls by calls to our embedded pihole-FTL sqlite3 engine and remove sqlite3 as dependency in the installer.
...
Signed-off-by: DL6ER <dl6er@dl6er.de>
2 years ago
MichaIng
c2080324b7
Install netcat-openbsd as dependency explicitly
...
Since Debian Stretch and Ubuntu Bionic, the "netcat" package is a transitional dummy package which pulls in "netcat-traditional" on Debian Stretch+Buster and Ubuntu Bionic, and "netcat-openbsd" on Debian Bullseye, Ubuntu Focal and up.
On Debian Bookworm (testing), however, the "netcat" package has been removed during the last 3 days at time or writing, so that it fails do be installed. While "netcat-traditional" and "netcat-openbsd" both "Provides: netcat", since it's two alternatives, APT does not automatically pick one but aborts, and the only solution is to install one explicitly.
While this is likely a temporary state of the Debian testing suite, having a closer look at the two alternatives shows that "netcat-openbsd" is a much more actively maintained newer version with additional support for IPv6, proxies, and UNIX sockets, which is likely the reason for the gradual transition via meta package from "netcat-traditional" to "netcat-openbsd". This commit hence consequently follows this aim by skipping the transitional dummy package and installing "netcat-openbsd" explicitly as dependency, to avoid any possible errors like the one which occurs currently on Bookworm.
Both packages can be installed concurrently and do no conflict, but are managed via dpkg's "update-alternatives".
For reference:
- https://packages.debian.org/netcat
- https://packages.ubuntu.com/netcat
Signed-off-by: MichaIng <micha@dietpi.com>
2 years ago