Dan Schaper
d9528dfd09
Bash is funny with returns.
8 years ago
Dan Schaper
9c83825cb8
Merge branch 'feature/defensiveTweaks' of https://github.com/pi-hole/pi-hole into feature/defensiveTweaks
8 years ago
Dan Schaper
7a22471787
New naming convention, and reorder functions as bash would prefer them to be.
8 years ago
diginc
c30478bf4a
cleanup and use sentintel in is_repo
8 years ago
diginc
d986746ef9
missing quote added
8 years ago
diginc
a8fa061f2e
quote all the assignments prevent accidental glob splitting
8 years ago
Dan Schaper
bdd240ecb6
Shellcheck catch for always true expansion.
8 years ago
Dan Schaper
04da292df9
Missed one spinner, updated and exit script if github is unreachable.
8 years ago
Dan Schaper
85b8676b8e
Remove spinner, no functions here should last that long, and it masks a few potential exit avenues.
8 years ago
Dan Schaper
114bc13c23
Specify path, cron may not know where the files are located.
8 years ago
Dan Schaper
5fef5f1ed4
Break down `is_repo` to make sure it does what is expected.
8 years ago
Dan Schaper
807b60b0e6
Missed the second reinstaller....
8 years ago
Dan Schaper
fbc800e556
If unattened reinstall fails, notify user and exit script immediately.
8 years ago
Dan Schaper
1991ee7a7d
Google Style Guide. `readonly` and cap constants.
8 years ago
Dan Schaper
ffbfadbccf
Detail what the script does.
8 years ago
Dan Schaper
c3e2bce956
Variables declared as strings, make sure they are strings when we use them in functions.
8 years ago
Dan Schaper
0c9520d7e3
Protect against unexepcted return values (GitHub not responding as we'd expect.) And make sure bash doesn't maul the variables and cause firing of unattended reinstall of application when values returned aren't as expected.
8 years ago
Dan Schaper
1e7e5230cc
Clarify what exactly is being called and the expected returned value format
8 years ago
Dan Schaper
f1efc97357
Clairfy condition to make sure they operate as per the specs of the logic flow layout.
8 years ago
Marcus Hildum
69ba8a3c2f
Consistency
...
Again trying to move the repo to one style. Doesn't matter if it's
changed afterwards, but one style instead of about five seems
saner.
8 years ago
Marcus Hildum
28eeaf201b
Standardize function declaration
...
There were no fewer than three styles of function declaration going
on in these files, so I attempted to standardize them to the typical
myfucn() {
}
style.
8 years ago
Adam Warner
27d6e5d8cf
Complete overhaul of update logic. Moved to seperate script
8 years ago
Adam Warner
ce46c4dec4
remove prematurely added code
8 years ago
Adam Warner
29ad2496b6
don't output "elevating with sudo" in pihole script, just do it.
8 years ago