Commit Graph

108 Commits (master)

Author SHA1 Message Date
DL6ER 5e28e6b9ac
Removed remaining git -C
8 years ago
Dan Schaper 3365ef7aaa
`is_repo()` returns values to caller, silence function.
8 years ago
Dan Schaper 68c17b26dc
Bashisms
8 years ago
Dan Schaper e647efd471
Shell script, not javascript
8 years ago
DL6ER 15db1ffdd5
Remove variables not needed any more
8 years ago
DL6ER 4632b0f797
Updated updater logic
8 years ago
DL6ER 65c35a5530
Use new subroutine to determine if updates are available
8 years ago
DL6ER c449a1c0e0
Added GitCheckUpdateAvail()
8 years ago
DL6ER b020010f0d
Removed some of the &> /dev/null
8 years ago
DL6ER 0276c72fe2
replace 'git -C' with long version (see #1009)
8 years ago
Promofaux 2f976504e8 switch out -eq for ==
8 years ago
Dan Schaper f7d0de53bb Compare string to string.
8 years ago
Dan Schaper 603ec997ba Remove testing block.
8 years ago
Dan Schaper f7266ef4c8 Version remote check returns -1 on failure to detect curl silent failing. Update detects loss of contact to GitHub or fallthrough condition and reports to user.
8 years ago
Dan Schaper 3d43e1568c Use explicit calls for function to self-document
8 years ago
Dan Schaper c1a3f003e8 Rename the only utilty function left that didn't say `repo`
8 years ago
Dan Schaper 3f61aea7fc Utility functions fully quiet now. Calling functions have the echos.
8 years ago
Dan Schaper bd68db51e0 ShellCheck split local declaration and assignment.
8 years ago
Dan Schaper b8a5ed710e Take echos out of utility functions and move up a level.
8 years ago
Dan Schaper 34be601dd7 Test for lexicographically less than tag version.
8 years ago
Dan Schaper 1d64ad1ccd Stash all changed files, clean directory and pull updates.
8 years ago
Dan Schaper f2d7a3d26d Merge branch 'feature/defensiveTweaks' of https://github.com/pi-hole/pi-hole into feature/defensiveTweaks
8 years ago
Adam Warner ee37c37cab fix update output logic. version number variables should not be read only!
8 years ago
Dan Schaper b636c1e1f8 Whitespace.
8 years ago
Dan Schaper 8b9f0487c0 Merge branch 'feature/defensiveTweaks' of https://github.com/pi-hole/pi-hole into feature/defensiveTweaks
8 years ago
Dan Schaper ece1667fb0 Refactor and move some bits.
8 years ago
Adam Warner 50bd8b4a09 Further tweaks to local repo handling
8 years ago
Dan Schaper 93d91353a1 All tabs now spaced
8 years ago
Dan Schaper 8dc9143b34 Just delete, no need to cd there first.
8 years ago
Dan Schaper a0d9a1133c Factoring and combining functions
8 years ago
Dan Schaper 035e4bf727 Move value checks to `if` calls.
8 years ago
Dan Schaper 9ec5bbd560 Actually get `is_repo` to return a value and have it expected.
8 years ago
Dan Schaper 34482c5ed6 Modified `is_repo`
8 years ago
Dan Schaper 7d414b5628 Move version messages to main function, check for repos.
8 years ago
Dan Schaper d9528dfd09 Bash is funny with returns.
8 years ago
Dan Schaper 9c83825cb8 Merge branch 'feature/defensiveTweaks' of https://github.com/pi-hole/pi-hole into feature/defensiveTweaks
8 years ago
Dan Schaper 7a22471787 New naming convention, and reorder functions as bash would prefer them to be.
8 years ago
diginc c30478bf4a cleanup and use sentintel in is_repo
8 years ago
diginc d986746ef9 missing quote added
8 years ago
diginc a8fa061f2e quote all the assignments prevent accidental glob splitting
8 years ago
Dan Schaper bdd240ecb6 Shellcheck catch for always true expansion.
8 years ago
Dan Schaper 04da292df9 Missed one spinner, updated and exit script if github is unreachable.
8 years ago
Dan Schaper 85b8676b8e Remove spinner, no functions here should last that long, and it masks a few potential exit avenues.
8 years ago
Dan Schaper 114bc13c23 Specify path, cron may not know where the files are located.
8 years ago
Dan Schaper 5fef5f1ed4 Break down `is_repo` to make sure it does what is expected.
8 years ago
Dan Schaper 807b60b0e6 Missed the second reinstaller....
8 years ago
Dan Schaper fbc800e556 If unattened reinstall fails, notify user and exit script immediately.
8 years ago
Dan Schaper 1991ee7a7d Google Style Guide. `readonly` and cap constants.
8 years ago
Dan Schaper ffbfadbccf Detail what the script does.
8 years ago
Dan Schaper c3e2bce956 Variables declared as strings, make sure they are strings when we use them in functions.
8 years ago
Dan Schaper 0c9520d7e3 Protect against unexepcted return values (GitHub not responding as we'd expect.) And make sure bash doesn't maul the variables and cause firing of unattended reinstall of application when values returned aren't as expected.
8 years ago
Dan Schaper 1e7e5230cc Clarify what exactly is being called and the expected returned value format
8 years ago
Dan Schaper f1efc97357 Clairfy condition to make sure they operate as per the specs of the logic flow layout.
8 years ago
Marcus Hildum 69ba8a3c2f Consistency
8 years ago
Marcus Hildum 28eeaf201b Standardize function declaration
8 years ago
Adam Warner 27d6e5d8cf Complete overhaul of update logic. Moved to seperate script
8 years ago
Adam Warner ce46c4dec4 remove prematurely added code
8 years ago
Adam Warner 29ad2496b6 don't output "elevating with sudo" in pihole script, just do it.
8 years ago