diff --git a/advanced/Scripts/webpage.sh b/advanced/Scripts/webpage.sh index b6d500cd..d87def14 100755 --- a/advanced/Scripts/webpage.sh +++ b/advanced/Scripts/webpage.sh @@ -216,6 +216,18 @@ SetDNSDomainName(){ } +SetPrivacyMode(){ + + # Remove setting from file (create backup setupVars.conf.bak) + sed -i.bak '/API_PRIVACY_MODE/d' /etc/pihole/setupVars.conf + # Save setting to file + if [[ "${args[2]}" == "true" ]] ; then + echo "API_PRIVACY_MODE=true" >> /etc/pihole/setupVars.conf + else + echo "API_PRIVACY_MODE=false" >> /etc/pihole/setupVars.conf + fi +} + ResolutionSettings() { typ=${args[2]} @@ -246,6 +258,7 @@ case "${args[1]}" in "layout" ) SetWebUILayout;; "-h" | "--help" ) helpFunc;; "domainname" ) SetDNSDomainName;; + "privacymode" ) SetPrivacyMode;; "resolve" ) ResolutionSettings;; * ) helpFunc;; esac diff --git a/automated install/basic-install.sh b/automated install/basic-install.sh index 0e251575..f5371a89 100755 --- a/automated install/basic-install.sh +++ b/automated install/basic-install.sh @@ -63,7 +63,7 @@ else echo ":::" echo "::: Detecting the presence of the sudo utility for continuation of this install..." - if [ -x "$(command -v sudo)" ]; then + if command -v sudo &> /dev/null; then echo "::: Utility sudo located." exec curl -sSL https://install.pi-hole.net | sudo bash "$@" exit $? @@ -75,7 +75,7 @@ fi # Compatibility -if [[ $(command -v apt-get) ]]; then +if command -v apt-get &> /dev/null; then #Debian Family ############################################# PKG_MANAGER="apt-get" @@ -97,9 +97,9 @@ if [[ $(command -v apt-get) ]]; then LIGHTTPD_CFG="lighttpd.conf.debian" DNSMASQ_USER="dnsmasq" -elif [ $(command -v rpm) ]; then +elif command -v rpm &> /dev/null; then # Fedora Family - if [ $(command -v dnf) ]; then + if command -v dnf &> /dev/null; then PKG_MANAGER="dnf" else PKG_MANAGER="yum" @@ -119,6 +119,7 @@ elif [ $(command -v rpm) ]; then LIGHTTPD_GROUP="lighttpd" LIGHTTPD_CFG="lighttpd.conf.fedora" DNSMASQ_USER="nobody" + else echo "OS distribution not supported" exit @@ -413,7 +414,7 @@ setStaticIPv4() { echo "USERCTL=no" }> "${IFCFG_FILE}" ip addr replace dev "${PIHOLE_INTERFACE}" "${IPV4_ADDRESS}" - if [ -x "$(command -v nmcli)" ];then + if command -v nmcli &> /dev/null;then # Tell NetworkManager to read our new sysconfig file nmcli con load "${IFCFG_FILE}" > /dev/null fi @@ -673,7 +674,7 @@ stop_service() { # Can softfail, as process may not be installed when this is called echo ":::" echo -n "::: Stopping ${1} service..." - if [ -x "$(command -v systemctl)" ]; then + if command -v systemctl &> /dev/null; then systemctl stop "${1}" &> /dev/null || true else service "${1}" stop &> /dev/null || true @@ -686,7 +687,7 @@ start_service() { # This should not fail, it's an error if it does echo ":::" echo -n "::: Starting ${1} service..." - if [ -x "$(command -v systemctl)" ]; then + if command -v systemctl &> /dev/null; then systemctl restart "${1}" &> /dev/null else service "${1}" restart &> /dev/null @@ -698,7 +699,7 @@ enable_service() { # Enable service so that it will start with next reboot echo ":::" echo -n "::: Enabling ${1} service to start on reboot..." - if [ -x "$(command -v systemctl)" ]; then + if command -v systemctl &> /dev/null; then systemctl enable "${1}" &> /dev/null else update-rc.d "${1}" defaults &> /dev/null @@ -884,10 +885,10 @@ create_pihole_user() { configureFirewall() { # Allow HTTP and DNS traffic - if [ -x "$(command -v firewall-cmd)" ]; then + if command -v firewall-cmd &> /dev/null; then firewall-cmd --state &> /dev/null && ( echo "::: Configuring firewalld for httpd and dnsmasq.." && firewall-cmd --permanent --add-port=80/tcp && firewall-cmd --permanent --add-port=53/tcp \ && firewall-cmd --permanent --add-port=53/udp && firewall-cmd --reload) || echo "::: FirewallD not enabled" - elif [ -x "$(command -v iptables)" ]; then + elif command -v iptables &> /dev/null; then echo "::: Configuring iptables for httpd and dnsmasq.." iptables -A INPUT -p tcp -m tcp --dport 80 -j ACCEPT iptables -A INPUT -p tcp -m tcp --dport 53 -j ACCEPT @@ -969,7 +970,7 @@ updatePihole() { checkSelinux() { - if [ -x "$(command -v getenforce)" ]; then + if command -v getenforce &> /dev/null; then echo ":::" echo -n "::: SELinux Support Detected... Mode: " enforceMode=$(getenforce)