From 95a28ae1257e1500d2b1ff1fb910698d6f4834ba Mon Sep 17 00:00:00 2001 From: Craig Mayhew Date: Wed, 28 Oct 2020 18:29:22 +0000 Subject: [PATCH] unset() now also occurs for $splashPage After some email discussion with Adam, there is a preference to also prevent $splashPage from using variables Signed-off-by: craigmayhew --- advanced/index.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/advanced/index.php b/advanced/index.php index f0ac382b..ca8c35e4 100644 --- a/advanced/index.php +++ b/advanced/index.php @@ -57,10 +57,10 @@ if ($serverName === "pi.hole" } elseif (filter_var($serverName, FILTER_VALIDATE_IP) || in_array($serverName, $authorizedHosts)) { // When directly browsing via IP or authorized hostname // Render splash/landing page based off presence of $landPage file + // Unset variables so as to not be included in $landPage or $splashPage + unset($serverName, $svPasswd, $svEmail, $authorizedHosts, $validExtTypes, $currentUrlExt, $viewPort); // If $landPage file is present if (is_file(getcwd()."/$landPage")) { - //Unset variables so as to not be included in $landPage - unset($serverName, $svPasswd, $svEmail, $authorizedHosts, $validExtTypes, $currentUrlExt, $viewPort); include $landPage; exit(); }