From 699e29934521587066f001800f09e76badc0a1d4 Mon Sep 17 00:00:00 2001 From: diginc Date: Wed, 2 Nov 2016 23:40:50 -0500 Subject: [PATCH] add a comment about bash vs dash. future refact needed --- test/test_automated_install.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/test_automated_install.py b/test/test_automated_install.py index b720b94d..6a3daf60 100644 --- a/test/test_automated_install.py +++ b/test/test_automated_install.py @@ -110,5 +110,8 @@ def run_script(Pihole, script, file="/test.sh"): def _write_test_script(Pihole, script, file): ''' Running the test script blocks directly can behave differently with regard to global vars ''' ''' this is a cheap work around to that until all functions no longer rely on global variables ''' + ''' found out why, dash: is the default in testinfra run() for Docker + Should try and convert the tests using this to firewalld style test + or override the run() function to use bash instead ''' Pihole.run('cat < {file}\n{script}\nEOF'.format(file=file, script=script)) Pihole.run('chmod +x {}'.format(file))