arno/pi-hole
1
0
Fork 0
mirror of https://github.com/pi-hole/pi-hole synced 2025-01-08 23:20:56 +00:00
Code Issues Releases Wiki Activity

Error check.

Browse Source
This commit is contained in:
Dan Schaper 2017-01-28 16:33:40 -08:00
parent 737819b56e
commit 585f842206
No known key found for this signature in database
GPG Key ID: 572E999E385B7BFC
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
automated install/basic-install.sh
View File

@ -703,6 +703,8 @@ update_package_cache() {
echo -n "::: Updating local cache of available packages..." echo -n "::: Updating local cache of available packages..."
if eval ${UPDATE_PKG_CACHE}; then if eval ${UPDATE_PKG_CACHE}; then
echo " done!" echo " done!"
else
echo -n "\n!!! ERROR - Unable to update package cache. Please try \"${UPDATE_PKG_CACHE}\""
fi fi
} }

5
test/test_automated_install.py
View File

@ -285,14 +285,15 @@ def test_update_package_cache_success_no_errors(Pihole):
assert 'done!' in updateCache.stdout assert 'done!' in updateCache.stdout
def test_update_package_cache_failure_no_errors(Pihole): def test_update_package_cache_failure_no_errors(Pihole):
''' confirms package cache was updated without any errors''' ''' confirms package cache was not updated'''
mock_command('apt-get', {'*':('', '1')}, Pihole) mock_command('apt-get', {'update':('', '1')}, Pihole)
updateCache = Pihole.run(''' updateCache = Pihole.run('''
source /opt/pihole/basic-install.sh source /opt/pihole/basic-install.sh
distro_check distro_check
update_package_cache update_package_cache
''') ''')
assert 'Updating local cache of available packages...' in updateCache.stdout assert 'Updating local cache of available packages...' in updateCache.stdout
assert 'ERROR' in updateCache.stdout
assert 'done!' not in updateCache.stdout assert 'done!' not in updateCache.stdout
# Helper functions # Helper functions