From 31951dae4c8dbefb7606251dfa800fcefe6614df Mon Sep 17 00:00:00 2001
From: Rob Gill <rrobgill@protonmail.com>
Date: Fri, 11 May 2018 14:31:42 +1000
Subject: [PATCH 1/4] Update index.php

Avoiding calling empty() on a function allows this to work under PHP5. Making the check for blocklist generation in this way instead is compatible with both PHP5 and PHP7.

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
---
 advanced/index.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/advanced/index.php b/advanced/index.php
index d097fe0f..041939a7 100644
--- a/advanced/index.php
+++ b/advanced/index.php
@@ -102,7 +102,8 @@ if ($serverName === "pi.hole") {
 $bpAskAdmin = !empty($svEmail) ? '<a href="mailto:'.$svEmail.'?subject=Site Blocked: '.$serverName.'"></a>' : "<span/>";
 
 // Determine if at least one block list has been generated
-if (empty(glob("/etc/pihole/list.0.*.domains")))
+$blocklistglob = glob("/etc/pihole/list.0.*.domains");
+if ($blocklistglob = "")
     die("[ERROR] There are no domain lists generated lists within <code>/etc/pihole/</code>! Please update gravity by running <code>pihole -g</code>, or repair Pi-hole using <code>pihole -r</code>.");
 
 // Set location of adlists file

From 5e99baf7b9b9ae81ec3d07dd44919732d8dc31fc Mon Sep 17 00:00:00 2001
From: Rob Gill <rrobgill@protonmail.com>
Date: Fri, 11 May 2018 14:52:30 +1000
Subject: [PATCH 2/4] Update index.php

thanks stickler-ci  .......

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
---
 advanced/index.php | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/advanced/index.php b/advanced/index.php
index 041939a7..0f22908f 100644
--- a/advanced/index.php
+++ b/advanced/index.php
@@ -103,8 +103,9 @@ $bpAskAdmin = !empty($svEmail) ? '<a href="mailto:'.$svEmail.'?subject=Site Bloc
 
 // Determine if at least one block list has been generated
 $blocklistglob = glob("/etc/pihole/list.0.*.domains");
-if ($blocklistglob = "")
+if ($blocklistglob = "") {
     die("[ERROR] There are no domain lists generated lists within <code>/etc/pihole/</code>! Please update gravity by running <code>pihole -g</code>, or repair Pi-hole using <code>pihole -r</code>.");
+}
 
 // Set location of adlists file
 if (is_file("/etc/pihole/adlists.list")) {

From 9379487942ec0f9f733ac18de7b9a215503190ca Mon Sep 17 00:00:00 2001
From: Rob Gill <rrobgill@protonmail.com>
Date: Sat, 12 May 2018 10:49:01 +1000
Subject: [PATCH 3/4] changes as requested

changes as requested

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
---
 advanced/index.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/advanced/index.php b/advanced/index.php
index 0f22908f..5503d604 100644
--- a/advanced/index.php
+++ b/advanced/index.php
@@ -103,7 +103,7 @@ $bpAskAdmin = !empty($svEmail) ? '<a href="mailto:'.$svEmail.'?subject=Site Bloc
 
 // Determine if at least one block list has been generated
 $blocklistglob = glob("/etc/pihole/list.0.*.domains");
-if ($blocklistglob = "") {
+if($blocklistglob === array()) {
     die("[ERROR] There are no domain lists generated lists within <code>/etc/pihole/</code>! Please update gravity by running <code>pihole -g</code>, or repair Pi-hole using <code>pihole -r</code>.");
 }
 

From 382c19024f6d7927a3684e9a77f7ae3e4252fdf6 Mon Sep 17 00:00:00 2001
From: Rob Gill <rrobgill@protonmail.com>
Date: Sat, 12 May 2018 10:53:44 +1000
Subject: [PATCH 4/4] oh stickler bot...

accidentally a space

Signed-off-by: Rob Gill <rrobgill@protonmail.com>
---
 advanced/index.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/advanced/index.php b/advanced/index.php
index 5503d604..1575bafc 100644
--- a/advanced/index.php
+++ b/advanced/index.php
@@ -103,7 +103,7 @@ $bpAskAdmin = !empty($svEmail) ? '<a href="mailto:'.$svEmail.'?subject=Site Bloc
 
 // Determine if at least one block list has been generated
 $blocklistglob = glob("/etc/pihole/list.0.*.domains");
-if($blocklistglob === array()) {
+if ($blocklistglob === array()) {
     die("[ERROR] There are no domain lists generated lists within <code>/etc/pihole/</code>! Please update gravity by running <code>pihole -g</code>, or repair Pi-hole using <code>pihole -r</code>.");
 }