1
0
mirror of https://github.com/pi-hole/pi-hole synced 2024-12-22 14:58:08 +00:00

Use explicit calls for function to self-document

This commit is contained in:
Dan Schaper 2016-11-02 11:39:22 -07:00
parent c1a3f003e8
commit 3d43e1568c
2 changed files with 7 additions and 10 deletions

3
.gitignore vendored
View File

@ -3,4 +3,5 @@
*.swp *.swp
__pycache__ __pycache__
.cache .cache
*.yml .pullapprove.yml

View File

@ -89,15 +89,11 @@ main() {
fi fi
echo "::: Checking for updates..." echo "::: Checking for updates..."
# Checks Pi-hole version > pihole only > current local git repo version : returns string in format vX.X.X # Checks Pi-hole version string in format vX.X.X
pihole_version_current="$(/usr/local/bin/pihole -v -p -c)" pihole_version_current="$(/usr/local/bin/pihole version --pihole --current)"
# Checks Pi-hole version > pihole only > remote upstream repo version : returns string in format vX.X.X pihole_version_latest="$(/usr/local/bin/pihole version --pihole --latest)"
pihole_version_latest="$(/usr/local/bin/pihole -v -p -l)" web_version_current="$(/usr/local/bin/pihole version --admin --current)"
web_version_latest="$(/usr/local/bin/pihole version --admin --latest)"
# Checks Pi-hole version > admin only > current local git repo version : returns string in format vX.X.X
web_version_current="$(/usr/local/bin/pihole -v -a -c)"
# Checks Pi-hole version > admin only > remote upstream repo version : returns string in format vX.X.X
web_version_latest="$(/usr/local/bin/pihole -v -a -l)"
# Logic # Logic
# If latest versions are blank - we've probably hit Github rate limit (stop running `pihole -up so often!): # If latest versions are blank - we've probably hit Github rate limit (stop running `pihole -up so often!):