From b52a3a021daa77f0605316c8e07f744514d2731d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20K=C3=B6nig?= Date: Mon, 6 Dec 2021 20:27:13 +0100 Subject: [PATCH 1/3] Add comment help text to list function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Christian König --- advanced/Scripts/list.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/advanced/Scripts/list.sh b/advanced/Scripts/list.sh index bc254515..fda8603c 100755 --- a/advanced/Scripts/list.sh +++ b/advanced/Scripts/list.sh @@ -91,7 +91,8 @@ Options: -q, --quiet Make output less verbose -h, --help Show this help dialog -l, --list Display all your ${listname}listed domains - --nuke Removes all entries in a list" + --nuke Removes all entries in a list + --comment Add a comment to the domain. If adding multiple domains the same comment will be used for all" exit 0 } From 669f1b0f4ab1f27ed5c7b29e363ef1beb395f4fb Mon Sep 17 00:00:00 2001 From: yubiuser Date: Tue, 21 Dec 2021 12:58:39 +0100 Subject: [PATCH 2/3] Address reviewer's comment Co-authored-by: DL6ER --- advanced/Scripts/list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/advanced/Scripts/list.sh b/advanced/Scripts/list.sh index fda8603c..ffde075a 100755 --- a/advanced/Scripts/list.sh +++ b/advanced/Scripts/list.sh @@ -92,7 +92,7 @@ Options: -h, --help Show this help dialog -l, --list Display all your ${listname}listed domains --nuke Removes all entries in a list - --comment Add a comment to the domain. If adding multiple domains the same comment will be used for all" + --comment "text" Add a comment to the domain. If adding multiple domains the same comment will be used for all" exit 0 } From ff4487ff749dcaa7eaf2b72ecaeb068209831fcd Mon Sep 17 00:00:00 2001 From: yubiuser Date: Tue, 21 Dec 2021 22:10:56 +0100 Subject: [PATCH 3/3] Escape quotes Co-authored-by: DL6ER --- advanced/Scripts/list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/advanced/Scripts/list.sh b/advanced/Scripts/list.sh index ffde075a..8945047e 100755 --- a/advanced/Scripts/list.sh +++ b/advanced/Scripts/list.sh @@ -92,7 +92,7 @@ Options: -h, --help Show this help dialog -l, --list Display all your ${listname}listed domains --nuke Removes all entries in a list - --comment "text" Add a comment to the domain. If adding multiple domains the same comment will be used for all" + --comment \"text\" Add a comment to the domain. If adding multiple domains the same comment will be used for all" exit 0 }