mirror of
https://github.com/aquasecurity/kube-bench.git
synced 2024-12-24 07:28:06 +00:00
01c77b2315
* read-only-port defaults are correct * Tests that should catch good read-only-port * Rework checks & tests * Linting on issue template YAML * More explicit test for 4.2.4 * Remove verbosity for ease of reading results * Use subtests * Tidy more test cases
808 lines
25 KiB
Go
808 lines
25 KiB
Go
// Copyright © 2017-2020 Aqua Security Software Ltd. <info@aquasec.com>
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package check
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
var (
|
|
in []byte
|
|
controls *Controls
|
|
)
|
|
|
|
func init() {
|
|
var err error
|
|
in, err = ioutil.ReadFile("data")
|
|
if err != nil {
|
|
panic("Failed reading test data: " + err.Error())
|
|
}
|
|
|
|
// substitute variables in data file
|
|
user := os.Getenv("USER")
|
|
s := strings.Replace(string(in), "$user", user, -1)
|
|
|
|
controls, err = NewControls(MASTER, []byte(s))
|
|
// controls, err = NewControls(MASTER, in)
|
|
if err != nil {
|
|
panic("Failed creating test controls: " + err.Error())
|
|
}
|
|
}
|
|
|
|
func TestTestExecute(t *testing.T) {
|
|
|
|
cases := []struct {
|
|
*Check
|
|
str string
|
|
strConfig string
|
|
}{
|
|
{
|
|
controls.Groups[0].Checks[0],
|
|
"2:45 ../kubernetes/kube-apiserver --allow-privileged=false --option1=20,30,40",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[1],
|
|
"2:45 ../kubernetes/kube-apiserver --allow-privileged=false",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[2],
|
|
"niinai 13617 2635 99 19:26 pts/20 00:03:08 ./kube-apiserver --insecure-port=0 --anonymous-auth",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[3],
|
|
"2:45 ../kubernetes/kube-apiserver --secure-port=0 --audit-log-maxage=40 --option",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[4],
|
|
"2:45 ../kubernetes/kube-apiserver --max-backlog=20 --secure-port=0 --audit-log-maxage=40 --option",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[5],
|
|
"2:45 ../kubernetes/kube-apiserver --option --admission-control=WebHook,RBAC ---audit-log-maxage=40",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[6],
|
|
"2:45 .. --kubelet-clientkey=foo --kubelet-client-certificate=bar --admission-control=Webhook,RBAC",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[7],
|
|
"2:45 .. --secure-port=0 --kubelet-client-certificate=bar --admission-control=Webhook,RBAC",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[8],
|
|
"644",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[9],
|
|
"640",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[9],
|
|
"600",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[10],
|
|
"2:45 ../kubernetes/kube-apiserver --option --admission-control=WebHook,RBAC ---audit-log-maxage=40",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[11],
|
|
"2:45 ../kubernetes/kube-apiserver --option --admission-control=WebHook,RBAC ---audit-log-maxage=40",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[12],
|
|
"2:45 ../kubernetes/kube-apiserver --option --admission-control=WebHook,Something,RBAC ---audit-log-maxage=40",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[13],
|
|
"2:45 ../kubernetes/kube-apiserver --option --admission-control=Something ---audit-log-maxage=40",
|
|
"",
|
|
},
|
|
{
|
|
// check for ':' as argument-value separator, with space between arg and val
|
|
controls.Groups[0].Checks[14],
|
|
"2:45 kube-apiserver some-arg: some-val --admission-control=Something ---audit-log-maxage=40",
|
|
"",
|
|
},
|
|
{
|
|
// check for ':' as argument-value separator, with no space between arg and val
|
|
controls.Groups[0].Checks[14],
|
|
"2:45 kube-apiserver some-arg:some-val --admission-control=Something ---audit-log-maxage=40",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[15],
|
|
"",
|
|
"{\"readOnlyPort\": 15000}",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[16],
|
|
"",
|
|
"{\"stringValue\": \"WebHook,Something,RBAC\"}",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[17],
|
|
"",
|
|
"{\"trueValue\": true}",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[18],
|
|
"",
|
|
"{\"readOnlyPort\": 15000}",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[19],
|
|
"",
|
|
"{\"authentication\": { \"anonymous\": {\"enabled\": false}}}",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[20],
|
|
"",
|
|
"readOnlyPort: 15000",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[21],
|
|
"",
|
|
"readOnlyPort: 15000",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[22],
|
|
"",
|
|
"authentication:\n anonymous:\n enabled: false",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[26],
|
|
"",
|
|
"currentMasterVersion: 1.12.7",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[27],
|
|
"--peer-client-cert-auth",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[27],
|
|
"--abc=true --peer-client-cert-auth --efg=false",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[27],
|
|
"--abc --peer-client-cert-auth --efg",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[27],
|
|
"--peer-client-cert-auth=true",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[27],
|
|
"--abc --peer-client-cert-auth=true --efg",
|
|
"",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[28],
|
|
"--abc --peer-client-cert-auth=false --efg",
|
|
"",
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.Text, func(t *testing.T) {
|
|
c.Check.AuditOutput = c.str
|
|
c.Check.AuditConfigOutput = c.strConfig
|
|
res, err := c.Check.execute()
|
|
if err != nil {
|
|
t.Errorf(err.Error())
|
|
}
|
|
if !res.testResult {
|
|
t.Errorf("expected:%v, got:%v", true, res)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestTestExecuteExceptions(t *testing.T) {
|
|
|
|
cases := []struct {
|
|
*Check
|
|
str string
|
|
}{
|
|
{
|
|
controls.Groups[0].Checks[23],
|
|
"this is not valid json {} at all",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[24],
|
|
"{\"key\": \"value\"}",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[25],
|
|
"broken } yaml\nenabled: true",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[26],
|
|
"currentMasterVersion: 1.11",
|
|
},
|
|
{
|
|
controls.Groups[0].Checks[26],
|
|
"currentMasterVersion: ",
|
|
},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.Text, func(t *testing.T) {
|
|
c.Check.AuditConfigOutput = c.str
|
|
res, err := c.Check.execute()
|
|
if err != nil {
|
|
t.Errorf(err.Error())
|
|
}
|
|
if res.testResult {
|
|
t.Errorf("expected:%v, got:%v", false, res)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestTestUnmarshal(t *testing.T) {
|
|
type kubeletConfig struct {
|
|
Kind string
|
|
ApiVersion string
|
|
Address string
|
|
}
|
|
cases := []struct {
|
|
content string
|
|
jsonInterface interface{}
|
|
expectedToFail bool
|
|
}{
|
|
{
|
|
`{
|
|
"kind": "KubeletConfiguration",
|
|
"apiVersion": "kubelet.config.k8s.io/v1beta1",
|
|
"address": "0.0.0.0"
|
|
}
|
|
`,
|
|
kubeletConfig{},
|
|
false,
|
|
}, {
|
|
`
|
|
kind: KubeletConfiguration
|
|
address: 0.0.0.0
|
|
apiVersion: kubelet.config.k8s.io/v1beta1
|
|
authentication:
|
|
anonymous:
|
|
enabled: false
|
|
webhook:
|
|
cacheTTL: 2m0s
|
|
enabled: true
|
|
x509:
|
|
clientCAFile: /etc/kubernetes/pki/ca.crt
|
|
tlsCipherSuites:
|
|
- TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
|
|
- TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
|
|
`,
|
|
kubeletConfig{},
|
|
false,
|
|
},
|
|
{
|
|
`
|
|
kind: ddress: 0.0.0.0
|
|
apiVersion: kubelet.config.k8s.io/v1beta
|
|
`,
|
|
kubeletConfig{},
|
|
true,
|
|
},
|
|
}
|
|
|
|
for id, c := range cases {
|
|
t.Run(fmt.Sprintf("%d", id), func(t *testing.T) {
|
|
err := unmarshal(c.content, &c.jsonInterface)
|
|
if err != nil {
|
|
if !c.expectedToFail {
|
|
t.Errorf("should pass, got error:%v", err)
|
|
}
|
|
} else {
|
|
if c.expectedToFail {
|
|
t.Errorf("should fail, but passed")
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestExecuteJSONPath(t *testing.T) {
|
|
type kubeletConfig struct {
|
|
Kind string
|
|
ApiVersion string
|
|
Address string
|
|
}
|
|
cases := []struct {
|
|
name string
|
|
jsonPath string
|
|
jsonInterface kubeletConfig
|
|
expectedResult string
|
|
expectedToFail bool
|
|
}{
|
|
{
|
|
"JSONPath parse works, results don't match",
|
|
"{.Kind}",
|
|
kubeletConfig{
|
|
Kind: "KubeletConfiguration",
|
|
ApiVersion: "kubelet.config.k8s.io/v1beta1",
|
|
Address: "127.0.0.0",
|
|
},
|
|
"blah",
|
|
true,
|
|
},
|
|
{
|
|
"JSONPath parse works, results match",
|
|
"{.Kind}",
|
|
kubeletConfig{
|
|
Kind: "KubeletConfiguration",
|
|
ApiVersion: "kubelet.config.k8s.io/v1beta1",
|
|
Address: "127.0.0.0",
|
|
},
|
|
"KubeletConfiguration",
|
|
false,
|
|
},
|
|
{
|
|
"JSONPath parse fails",
|
|
"{.ApiVersion",
|
|
kubeletConfig{
|
|
Kind: "KubeletConfiguration",
|
|
ApiVersion: "kubelet.config.k8s.io/v1beta1",
|
|
Address: "127.0.0.0",
|
|
},
|
|
"",
|
|
true,
|
|
},
|
|
}
|
|
for _, c := range cases {
|
|
t.Run(c.name, func(t *testing.T) {
|
|
result, err := executeJSONPath(c.jsonPath, c.jsonInterface)
|
|
if err != nil && !c.expectedToFail {
|
|
t.Fatalf("jsonPath:%q, expectedResult:%q got:%v", c.jsonPath, c.expectedResult, err)
|
|
}
|
|
if c.expectedResult != result && !c.expectedToFail {
|
|
t.Errorf("jsonPath:%q, expectedResult:%q got:%q", c.jsonPath, c.expectedResult, result)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestAllElementsValid(t *testing.T) {
|
|
cases := []struct {
|
|
source []string
|
|
target []string
|
|
valid bool
|
|
}{
|
|
{
|
|
source: []string{},
|
|
target: []string{},
|
|
valid: true,
|
|
},
|
|
{
|
|
source: []string{"blah"},
|
|
target: []string{},
|
|
valid: false,
|
|
},
|
|
{
|
|
source: []string{},
|
|
target: []string{"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
|
|
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305", "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
|
|
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305", "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
|
|
"TLS_RSA_WITH_AES_256_GCM_SHA384", "TLS_RSA_WITH_AES_128_GCM_SHA256"},
|
|
valid: false,
|
|
},
|
|
{
|
|
source: []string{"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256"},
|
|
target: []string{"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
|
|
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305", "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
|
|
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305", "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
|
|
"TLS_RSA_WITH_AES_256_GCM_SHA384", "TLS_RSA_WITH_AES_128_GCM_SHA256"},
|
|
valid: true,
|
|
},
|
|
{
|
|
source: []string{"blah"},
|
|
target: []string{"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
|
|
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305", "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
|
|
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305", "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
|
|
"TLS_RSA_WITH_AES_256_GCM_SHA384", "TLS_RSA_WITH_AES_128_GCM_SHA256"},
|
|
valid: false,
|
|
},
|
|
{
|
|
source: []string{"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256", "blah"},
|
|
target: []string{"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256", "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
|
|
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305", "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
|
|
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305", "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
|
|
"TLS_RSA_WITH_AES_256_GCM_SHA384", "TLS_RSA_WITH_AES_128_GCM_SHA256"},
|
|
valid: false,
|
|
},
|
|
}
|
|
for id, c := range cases {
|
|
t.Run(fmt.Sprintf("%d", id), func(t *testing.T) {
|
|
if !allElementsValid(c.source, c.target) && c.valid {
|
|
t.Errorf("Not All Elements in %q are found in %q", c.source, c.target)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestSplitAndRemoveLastSeparator(t *testing.T) {
|
|
cases := []struct {
|
|
source string
|
|
valid bool
|
|
elementCnt int
|
|
}{
|
|
{
|
|
source: "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,TLS_RSA_WITH_AES_256_GCM_SHA384,TLS_RSA_WITH_AES_128_GCM_SHA256",
|
|
valid: true,
|
|
elementCnt: 8,
|
|
},
|
|
{
|
|
source: "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,",
|
|
valid: true,
|
|
elementCnt: 2,
|
|
},
|
|
{
|
|
source: "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,",
|
|
valid: true,
|
|
elementCnt: 2,
|
|
},
|
|
{
|
|
source: "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, ",
|
|
valid: true,
|
|
elementCnt: 2,
|
|
},
|
|
{
|
|
source: " TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,",
|
|
valid: true,
|
|
elementCnt: 2,
|
|
},
|
|
}
|
|
|
|
for id, c := range cases {
|
|
t.Run(fmt.Sprintf("%d", id), func(t *testing.T) {
|
|
as := splitAndRemoveLastSeparator(c.source, defaultArraySeparator)
|
|
if len(as) == 0 && c.valid {
|
|
t.Errorf("Split did not work with %q", c.source)
|
|
}
|
|
|
|
if c.elementCnt != len(as) {
|
|
t.Errorf("Split did not work with %q expected: %d got: %d", c.source, c.elementCnt, len(as))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCompareOp(t *testing.T) {
|
|
cases := []struct {
|
|
label string
|
|
op string
|
|
flagVal string
|
|
compareValue string
|
|
expectedResultPattern string
|
|
testResult bool
|
|
}{
|
|
// Test Op not matching
|
|
{label: "empty - op", op: "", flagVal: "", compareValue: "", expectedResultPattern: "", testResult: false},
|
|
{label: "op=blah", op: "blah", flagVal: "foo", compareValue: "bar", expectedResultPattern: "", testResult: false},
|
|
|
|
// Test Op "eq"
|
|
{label: "op=eq, both empty", op: "eq", flagVal: "", compareValue: "", expectedResultPattern: "'' is equal to ''", testResult: true},
|
|
|
|
{label: "op=eq, true==true", op: "eq", flagVal: "true",
|
|
compareValue: "true",
|
|
expectedResultPattern: "'true' is equal to 'true'",
|
|
testResult: true},
|
|
|
|
{label: "op=eq, false==false", op: "eq", flagVal: "false",
|
|
compareValue: "false",
|
|
expectedResultPattern: "'false' is equal to 'false'",
|
|
testResult: true},
|
|
|
|
{label: "op=eq, false==true", op: "eq", flagVal: "false",
|
|
compareValue: "true",
|
|
expectedResultPattern: "'false' is equal to 'true'",
|
|
testResult: false},
|
|
|
|
{label: "op=eq, strings match", op: "eq", flagVal: "KubeletConfiguration",
|
|
compareValue: "KubeletConfiguration",
|
|
expectedResultPattern: "'KubeletConfiguration' is equal to 'KubeletConfiguration'",
|
|
testResult: true},
|
|
|
|
{label: "op=eq, flagVal=empty", op: "eq", flagVal: "",
|
|
compareValue: "KubeletConfiguration",
|
|
expectedResultPattern: "'' is equal to 'KubeletConfiguration'",
|
|
testResult: false},
|
|
|
|
{label: "op=eq, compareValue=empty", op: "eq", flagVal: "KubeletConfiguration",
|
|
compareValue: "",
|
|
expectedResultPattern: "'KubeletConfiguration' is equal to ''",
|
|
testResult: false},
|
|
|
|
// Test Op "noteq"
|
|
{label: "op=noteq, both empty", op: "noteq", flagVal: "",
|
|
compareValue: "", expectedResultPattern: "'' is not equal to ''",
|
|
testResult: false},
|
|
|
|
{label: "op=noteq, true!=true", op: "noteq", flagVal: "true",
|
|
compareValue: "true",
|
|
expectedResultPattern: "'true' is not equal to 'true'",
|
|
testResult: false},
|
|
|
|
{label: "op=noteq, false!=false", op: "noteq", flagVal: "false",
|
|
compareValue: "false",
|
|
expectedResultPattern: "'false' is not equal to 'false'",
|
|
testResult: false},
|
|
|
|
{label: "op=noteq, false!=true", op: "noteq", flagVal: "false",
|
|
compareValue: "true",
|
|
expectedResultPattern: "'false' is not equal to 'true'",
|
|
testResult: true},
|
|
|
|
{label: "op=noteq, strings match", op: "noteq", flagVal: "KubeletConfiguration",
|
|
compareValue: "KubeletConfiguration",
|
|
expectedResultPattern: "'KubeletConfiguration' is not equal to 'KubeletConfiguration'",
|
|
testResult: false},
|
|
|
|
{label: "op=noteq, flagVal=empty", op: "noteq", flagVal: "",
|
|
compareValue: "KubeletConfiguration",
|
|
expectedResultPattern: "'' is not equal to 'KubeletConfiguration'",
|
|
testResult: true},
|
|
|
|
{label: "op=noteq, compareValue=empty", op: "noteq", flagVal: "KubeletConfiguration",
|
|
compareValue: "",
|
|
expectedResultPattern: "'KubeletConfiguration' is not equal to ''",
|
|
testResult: true},
|
|
|
|
// Test Op "gt"
|
|
{label: "op=gt, both empty", op: "gt", flagVal: "",
|
|
compareValue: "", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
{label: "op=gt, 0 > 0", op: "gt", flagVal: "0",
|
|
compareValue: "0", expectedResultPattern: "0 is greater than 0",
|
|
testResult: false},
|
|
{label: "op=gt, 4 > 5", op: "gt", flagVal: "4",
|
|
compareValue: "5", expectedResultPattern: "4 is greater than 5",
|
|
testResult: false},
|
|
{label: "op=gt, 5 > 4", op: "gt", flagVal: "5",
|
|
compareValue: "4", expectedResultPattern: "5 is greater than 4",
|
|
testResult: true},
|
|
{label: "op=gt, 5 > 5", op: "gt", flagVal: "5",
|
|
compareValue: "5", expectedResultPattern: "5 is greater than 5",
|
|
testResult: false},
|
|
{label: "op=gt, Pikachu > 5", op: "gt", flagVal: "Pikachu",
|
|
compareValue: "5", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
{label: "op=gt, 5 > Bulbasaur", op: "gt", flagVal: "5",
|
|
compareValue: "Bulbasaur", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
// Test Op "lt"
|
|
{label: "op=lt, both empty", op: "lt", flagVal: "",
|
|
compareValue: "", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
{label: "op=lt, 0 < 0", op: "lt", flagVal: "0",
|
|
compareValue: "0", expectedResultPattern: "0 is lower than 0",
|
|
testResult: false},
|
|
{label: "op=lt, 4 < 5", op: "lt", flagVal: "4",
|
|
compareValue: "5", expectedResultPattern: "4 is lower than 5",
|
|
testResult: true},
|
|
{label: "op=lt, 5 < 4", op: "lt", flagVal: "5",
|
|
compareValue: "4", expectedResultPattern: "5 is lower than 4",
|
|
testResult: false},
|
|
{label: "op=lt, 5 < 5", op: "lt", flagVal: "5",
|
|
compareValue: "5", expectedResultPattern: "5 is lower than 5",
|
|
testResult: false},
|
|
{label: "op=lt, Charmander < 5", op: "lt", flagVal: "Charmander",
|
|
compareValue: "5", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
{label: "op=lt, 5 < Charmeleon", op: "lt", flagVal: "5",
|
|
compareValue: "Charmeleon", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
// Test Op "gte"
|
|
{label: "op=gte, both empty", op: "gte", flagVal: "",
|
|
compareValue: "", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
{label: "op=gte, 0 >= 0", op: "gte", flagVal: "0",
|
|
compareValue: "0", expectedResultPattern: "0 is greater or equal to 0",
|
|
testResult: true},
|
|
{label: "op=gte, 4 >= 5", op: "gte", flagVal: "4",
|
|
compareValue: "5", expectedResultPattern: "4 is greater or equal to 5",
|
|
testResult: false},
|
|
{label: "op=gte, 5 >= 4", op: "gte", flagVal: "5",
|
|
compareValue: "4", expectedResultPattern: "5 is greater or equal to 4",
|
|
testResult: true},
|
|
{label: "op=gte, 5 >= 5", op: "gte", flagVal: "5",
|
|
compareValue: "5", expectedResultPattern: "5 is greater or equal to 5",
|
|
testResult: true},
|
|
{label: "op=gte, Ekans >= 5", op: "gte", flagVal: "Ekans",
|
|
compareValue: "5", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
{label: "op=gte, 4 >= Zubat", op: "gte", flagVal: "4",
|
|
compareValue: "Zubat", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
// Test Op "lte"
|
|
{label: "op=lte, both empty", op: "lte", flagVal: "",
|
|
compareValue: "", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
{label: "op=lte, 0 <= 0", op: "lte", flagVal: "0",
|
|
compareValue: "0", expectedResultPattern: "0 is lower or equal to 0",
|
|
testResult: true},
|
|
{label: "op=lte, 4 <= 5", op: "lte", flagVal: "4",
|
|
compareValue: "5", expectedResultPattern: "4 is lower or equal to 5",
|
|
testResult: true},
|
|
{label: "op=lte, 5 <= 4", op: "lte", flagVal: "5",
|
|
compareValue: "4", expectedResultPattern: "5 is lower or equal to 4",
|
|
testResult: false},
|
|
{label: "op=lte, 5 <= 5", op: "lte", flagVal: "5",
|
|
compareValue: "5", expectedResultPattern: "5 is lower or equal to 5",
|
|
testResult: true},
|
|
{label: "op=lte, Venomoth <= 4", op: "lte", flagVal: "Venomoth",
|
|
compareValue: "4", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
{label: "op=lte, 5 <= Meowth", op: "lte", flagVal: "5",
|
|
compareValue: "Meowth", expectedResultPattern: "Invalid Number(s) used for comparison",
|
|
testResult: false},
|
|
|
|
// Test Op "has"
|
|
{label: "op=has, both empty", op: "has", flagVal: "",
|
|
compareValue: "", expectedResultPattern: "'' has ''",
|
|
testResult: true},
|
|
{label: "op=has, flagVal=empty", op: "has", flagVal: "",
|
|
compareValue: "blah", expectedResultPattern: "'' has 'blah'",
|
|
testResult: false},
|
|
{label: "op=has, compareValue=empty", op: "has", flagVal: "blah",
|
|
compareValue: "", expectedResultPattern: "'blah' has ''",
|
|
testResult: true},
|
|
{label: "op=has, 'blah' has 'la'", op: "has", flagVal: "blah",
|
|
compareValue: "la", expectedResultPattern: "'blah' has 'la'",
|
|
testResult: true},
|
|
{label: "op=has, 'blah' has 'LA'", op: "has", flagVal: "blah",
|
|
compareValue: "LA", expectedResultPattern: "'blah' has 'LA'",
|
|
testResult: false},
|
|
{label: "op=has, 'blah' has 'lo'", op: "has", flagVal: "blah",
|
|
compareValue: "lo", expectedResultPattern: "'blah' has 'lo'",
|
|
testResult: false},
|
|
|
|
// Test Op "nothave"
|
|
{label: "op=nothave, both empty", op: "nothave", flagVal: "",
|
|
compareValue: "", expectedResultPattern: " '' not have ''",
|
|
testResult: false},
|
|
{label: "op=nothave, flagVal=empty", op: "nothave", flagVal: "",
|
|
compareValue: "blah", expectedResultPattern: " '' not have 'blah'",
|
|
testResult: true},
|
|
{label: "op=nothave, compareValue=empty", op: "nothave", flagVal: "blah",
|
|
compareValue: "", expectedResultPattern: " 'blah' not have ''",
|
|
testResult: false},
|
|
{label: "op=nothave, 'blah' not have 'la'", op: "nothave", flagVal: "blah",
|
|
compareValue: "la", expectedResultPattern: " 'blah' not have 'la'",
|
|
testResult: false},
|
|
{label: "op=nothave, 'blah' not have 'LA'", op: "nothave", flagVal: "blah",
|
|
compareValue: "LA", expectedResultPattern: " 'blah' not have 'LA'",
|
|
testResult: true},
|
|
{label: "op=nothave, 'blah' not have 'lo'", op: "nothave", flagVal: "blah",
|
|
compareValue: "lo", expectedResultPattern: " 'blah' not have 'lo'",
|
|
testResult: true},
|
|
|
|
// Test Op "regex"
|
|
{label: "op=regex, both empty", op: "regex", flagVal: "",
|
|
compareValue: "", expectedResultPattern: " '' matched by ''",
|
|
testResult: true},
|
|
{label: "op=regex, flagVal=empty", op: "regex", flagVal: "",
|
|
compareValue: "blah", expectedResultPattern: " '' matched by 'blah'",
|
|
testResult: false},
|
|
|
|
// Test Op "valid_elements"
|
|
{label: "op=valid_elements, valid_elements both empty", op: "valid_elements", flagVal: "",
|
|
compareValue: "", expectedResultPattern: "'' contains valid elements from ''",
|
|
testResult: true},
|
|
|
|
{label: "op=valid_elements, valid_elements flagVal empty", op: "valid_elements", flagVal: "",
|
|
compareValue: "a,b", expectedResultPattern: "'' contains valid elements from 'a,b'",
|
|
testResult: false},
|
|
|
|
{label: "op=valid_elements, valid_elements expectedResultPattern empty", op: "valid_elements", flagVal: "a,b",
|
|
compareValue: "", expectedResultPattern: "'a,b' contains valid elements from ''",
|
|
testResult: false},
|
|
// Test Op "bitmask"
|
|
{label: "op=bitmask, 644 AND 640", op: "bitmask", flagVal: "640",
|
|
compareValue: "644", expectedResultPattern: "bitmask '640' AND '644'",
|
|
testResult: true},
|
|
{label: "op=bitmask, 644 AND 777", op: "bitmask", flagVal: "777",
|
|
compareValue: "644", expectedResultPattern: "bitmask '777' AND '644'",
|
|
testResult: false},
|
|
{label: "op=bitmask, 644 AND 444", op: "bitmask", flagVal: "444",
|
|
compareValue: "644", expectedResultPattern: "bitmask '444' AND '644'",
|
|
testResult: true},
|
|
{label: "op=bitmask, 644 AND 211", op: "bitmask", flagVal: "211",
|
|
compareValue: "644", expectedResultPattern: "bitmask '211' AND '644'",
|
|
testResult: false},
|
|
{label: "op=bitmask, Harry AND 211", op: "bitmask", flagVal: "Harry",
|
|
compareValue: "644", expectedResultPattern: "Not numeric value - flag: Harry",
|
|
testResult: false},
|
|
{label: "op=bitmask, 644 AND Potter", op: "bitmask", flagVal: "211",
|
|
compareValue: "Potter", expectedResultPattern: "Not numeric value - flag: Potter",
|
|
testResult: false},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.label, func(t *testing.T) {
|
|
expectedResultPattern, testResult := compareOp(c.op, c.flagVal, c.compareValue)
|
|
if expectedResultPattern != c.expectedResultPattern {
|
|
t.Errorf("'expectedResultPattern' did not match - op: %q expected:%q got:%q", c.op, c.expectedResultPattern, expectedResultPattern)
|
|
}
|
|
|
|
if testResult != c.testResult {
|
|
t.Errorf("'testResult' did not match - lop: %q expected:%t got:%t", c.op, c.testResult, testResult)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestToNumeric(t *testing.T) {
|
|
cases := []struct {
|
|
firstValue string
|
|
secondValue string
|
|
expectedToFail bool
|
|
}{
|
|
{
|
|
firstValue: "a",
|
|
secondValue: "b",
|
|
expectedToFail: true,
|
|
},
|
|
{
|
|
firstValue: "5",
|
|
secondValue: "b",
|
|
expectedToFail: true,
|
|
},
|
|
{
|
|
firstValue: "5",
|
|
secondValue: "6",
|
|
expectedToFail: false,
|
|
},
|
|
}
|
|
|
|
for id, c := range cases {
|
|
t.Run(fmt.Sprintf("%d", id), func(t *testing.T) {
|
|
f, s, err := toNumeric(c.firstValue, c.secondValue)
|
|
if c.expectedToFail && err == nil {
|
|
t.Errorf("Expected error while converting %s and %s", c.firstValue, c.secondValue)
|
|
}
|
|
|
|
if !c.expectedToFail && (f != 5 || s != 6) {
|
|
t.Errorf("Expected to return %d,%d - got %d,%d", 5, 6, f, s)
|
|
}
|
|
})
|
|
}
|
|
}
|