arno/kube-bench
1
0
Fork 0
mirror of https://github.com/aquasecurity/kube-bench.git synced 2024-12-18 12:48:08 +00:00
Code Issues Releases Wiki Activity

Fix Junit missing testsuites (#920)

Browse Source 
Fix issue https://github.com/aquasecurity/kube-bench/issues/883 but also bug with overriding output when --outputfile is effective and only write the last controls
This commit is contained in:
Yoav Rotem 2021-06-23 18:01:24 +03:00 committed by GitHub
parent aedc2942bd
commit 14aef408e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
cmd/common.go
View File

@ -437,13 +437,19 @@ func writeJSONOutput(controlsCollection []*check.Controls) {
} }
func writeJunitOutput(controlsCollection []*check.Controls) { func writeJunitOutput(controlsCollection []*check.Controls) {
// QuickFix for issue https://github.com/aquasecurity/kube-bench/issues/883
// Should consider to deprecate of switch to using Junit template
prefix := "<testsuites>\n"
suffix := "\n</testsuites>"
var outputAllControls []byte
for _, controls := range controlsCollection { for _, controls := range controlsCollection {
out, err := controls.JUnit() tempOut, err := controls.JUnit()
outputAllControls = append(outputAllControls[:], tempOut[:]...)
if err != nil { if err != nil {
exitWithError(fmt.Errorf("failed to output in JUnit format: %v", err)) exitWithError(fmt.Errorf("failed to output in JUnit format: %v", err))
} }
printOutput(string(out), outputFile)
} }
printOutput(prefix+string(outputAllControls)+suffix, outputFile)
} }
func writePgsqlOutput(controlsCollection []*check.Controls) { func writePgsqlOutput(controlsCollection []*check.Controls) {