9b0e3d29fe
revert incorrect removal of the internal server startup CLI
7 years ago
43623f349b
Fix: Truncate key-length when generating identicons
...
Hex-digits with character count above 17 cannot be safely converted to an Integer, see [MAX_SAFE_INTEGER](https://medium.com/the-node-js-collection/javascripts-number-type-8d59199db1b6#53cd ).
Therefore, when long keys (e.g. 32 characters) are passed into `generateIdenticon()`, and the modulus of 2^18 is performed, the result is 0 all the time. This means, the identicon will render as an empty svg image.
Here is a proof-of-concept (run in any modern browser):
```js
const key = '841b625dcf75413ff3ed5137a81ff1c3';
const int = parseInt(key, 16);
const hash = int % Math.pow(2, 18);
// throws, due to floating point conversion / integer overflow
console.assert(258499 === hash, "Modulus for 'hash' should be != 0");
const int2 = parseInt(key.substr(-16), 16);
const hash2 = int2 % Math.pow(2, 18);
// works as expected
console.assert(258048 === hash2, "Modulus 'hash2' should be != 0");
```
Truncating the passed in argument to a maximum of 16 characters solves the issue.
As a sidenote, the same code in Python will work correctly:
```python
key = '841b625dcf75413ff3ed5137a81ff1c3'
int = int(key, 16)
hash = int % pow(2, 18)
assert 258499 == hash
```
7 years ago
c3933bd9fd
fix sphinx build
7 years ago
c72946dc14
Run travis tests with python 3.5 & python 3.6
7 years ago
4c03a43c28
remove data-isso-id from documentation, it usually doesn't work as expected
7 years ago
e3a8d0b93d
fix db test with incorrect SQL id, that happened work with pre-3.6 dicts before
7 years ago
dc883e672a
Fix short title underline.
7 years ago
539e6e4486
Merge pull request #336 from jelmer/flakes
...
Fix pyflakes errors & run pyflakes on travis.
7 years ago
280b0d925a
Skip compat module when running flakes checks.
...
Python2-specific code fails on Python3 flakes and vice versa.
7 years ago
39debdb011
Fix flakes errors.
7 years ago
59b345b648
Run pyflakes on travis.
7 years ago
8c33a84dd3
Merge pull request #253 from jGleitz/apidoc
...
Update API documentation.
7 years ago
b8adfe3f18
Merge pull request #316 from shengbinmeng/patch-1
...
Better configure options for Chinese language
7 years ago
2f7d6aa09b
Merge branch 'master' into patch-1
7 years ago
71bda25568
Merge pull request #312 from pellenilsson/fix-require-email
...
Fix require-email setting
7 years ago
c8e4e74514
Merge pull request #335 from philipcmonk/time
...
Display only complete units of time
7 years ago
afbcb6413e
Add da entry to i18n.js.
7 years ago
6006cd9e82
Merge Danish translation from https://github.com/MadsRC/isso
7 years ago
26f0e06e78
display only complete units of time
...
fixes #283
7 years ago
616c61ea88
Merge pull request #291 from ivegotasthma/ivegotasthma-patch-1
...
fix: add missing i18n entry
7 years ago
a23317818f
Merge pull request #315 from ginggs/patch-1
...
add SOURCELINK_SUFFIX for compatibility with Sphinx 1.5
7 years ago
384673ebdb
Run travis tests with python 3.5 & python 3.6.
7 years ago
7bfe36bfdf
Specify Python versions to use in travis.
...
This should address python2.6 being missing in the default environment. Fixes #332
7 years ago
2f3cd0ac46
Merge pull request #325 from SilverRainZ/patch-1
...
Fix typo in isso.conf
7 years ago
fe4a1a11e9
Merge pull request #298 from kAworu/patch-2
...
api.rst: JSON and english typos
7 years ago
fd0147e8ab
Fixed typo in isso.conf
7 years ago
b14b1b51a9
validate->activate
7 years ago
cc8e61533f
Add templates to MANIFEST.in
7 years ago
84381f4f48
add: link to the thread
7 years ago
2adb779fef
add: edit author/email/website/message
7 years ago
e3fddf4ae8
add: orders in administration
7 years ago
3212bf762f
fix 500 error on pagination
7 years ago
0b6a0e4d5f
add: group by thread
7 years ago
1516f56cbd
fix: cursor pointer on links delete/validate
7 years ago
7a79746f73
add: show author email
7 years ago
0a93c866ff
Add a basic admin interface (Fix issue #10 )
...
Add a basic admin interface (Fix issue #10 )
wip again
still wip
fix login page
7 years ago
e9eebf58e3
Refactored comments unittest to work with optional gravatar feature
7 years ago
48a3bd72c8
Trigger
7 years ago
cbd4d90cb7
Added optional gravatar support
7 years ago
a9500e29dd
Add language "zh" as alias of "zh_CN"
7 years ago
4b7a32afac
Make the Chinese translations actually work
...
Before this change, the user must configure `lang="zh"` to use the CN version (neither `lang="zh_CN"` nor `lang="zh_TW"` works).
7 years ago
88aafa60e5
add SOURCELINK_SUFFIX for compatibility with Sphinx 1.5
...
With Sphinx 1.5, this is needed by searchtools.js to display the source
snippets (see sphinx-doc/sphinx#2454 ).
With earlier Sphinx versions, this is a no-op because the undefined variable
will evaluate to an empty string.
7 years ago
45a481daeb
Fix require-email setting, #308
7 years ago
d37b5bb030
Merge pull request #303 from MorrisJobke/highlight-links-in-text
...
Highlight links by underline in comments
7 years ago
f33ca31320
Highlight links by underline in comments
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
7 years ago
cd460ef152
Danish translation
8 years ago
03b0de2d81
api.rst: JSON and english typos
8 years ago
e853442468
Merge pull request #295 from kAworu/patch-1
...
default isso.conf typo
8 years ago
3d67f10c72
default isso.conf typo
8 years ago
f3b1d0ba07
Merge pull request #293 from ckoepp/master
...
added FreeBSD rc.d script
8 years ago
Martin Zimmermann