arno/isso
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

embed: fix feed link creation on older browsers

Browse Source 
When a browser doesn't support DOM manipulation convenience methods,
the addition of the feed link was triggering an error because elements
created by `$.new()` are regular elements, not elements from our own
mini-DOM implementation. Therefore, the `append()` method may be
absent. Use `appendChild()` instead.
This commit is contained in:
Vincent Bernat 2018-04-29 10:37:00 +02:00 committed by Vincent Bernat
parent 1d16db53da
commit fd46a7d86e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
isso/js/embed.js
View File

@ -37,7 +37,7 @@ require(["app/lib/ready", "app/config", "app/i18n", "app/api", "app/isso", "app/
var feedLink = $.new('a', i18n.translate('atom-feed')); var feedLink = $.new('a', i18n.translate('atom-feed'));
var feedLinkWrapper = $.new('span.isso-feedlink'); var feedLinkWrapper = $.new('span.isso-feedlink');
feedLink.href = api.feed(isso_thread.getAttribute("data-isso-id")); feedLink.href = api.feed(isso_thread.getAttribute("data-isso-id"));
feedLinkWrapper.append(feedLink); feedLinkWrapper.appendChild(feedLink);
isso_thread.append(feedLinkWrapper); isso_thread.append(feedLinkWrapper);
} }
isso_thread.append(heading); isso_thread.append(heading);