arno/isso
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #41 from spk/blank

Browse Source 
Add check with blank text
This commit is contained in:
Martin Zimmermann 2013-12-03 23:52:16 -08:00
commit 8802b73b52
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
isso/views/comments.py
View File

@ -109,7 +109,7 @@ class API(object):
if not isinstance(comment.get(key), (str, type(None))): if not isinstance(comment.get(key), (str, type(None))):
return False, "%s must be a string or null" % key return False, "%s must be a string or null" % key
if len(comment["text"]) < 3: if len(comment["text"].rstrip()) < 3:
return False, "text is too short (minimum length: 3)" return False, "text is too short (minimum length: 3)"
if len(comment.get("email") or "") > 254: if len(comment.get("email") or "") > 254:

6
specs/test_comments.py
View File

@ -102,6 +102,12 @@ class TestComments(unittest.TestCase):
rv = loads(r.data) rv = loads(r.data)
assert len(rv) == 20 assert len(rv) == 20
def testCreateBlank(self):
rv = self.post('/new?uri=%2Fpath%2F', data=json.dumps({'text': ''}))
assert rv.status_code == 400
rv = self.post('/new?uri=%2Fpath%2F', data=json.dumps({'text': "\n\n\n"}))
assert rv.status_code == 400
def testGetInvalid(self): def testGetInvalid(self):
assert self.get('/?uri=%2Fpath%2F&id=123').status_code == 404 assert self.get('/?uri=%2Fpath%2F&id=123').status_code == 404