arno/isso
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

remove semantic article, header and footer tags to avoid CSS collisions

Browse Source
This commit is contained in:
Martin Zimmermann 2013-10-19 11:38:16 +02:00
parent 9735037550
commit 66ade6df14
3 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
isso/css/isso.scss
View File

@ -60,11 +60,11 @@ a {
> div.text-wrapper { > div.text-wrapper {
@include span-columns(10 of 11); @include span-columns(10 of 11);
> header, > footer { > .isso-comment-header, > .isso-comment-footer {
font-size: 0.95em; font-size: 0.95em;
} }
> header { > .isso-comment-header {
font-family: "Helvetica", Arial, sans-serif; font-family: "Helvetica", Arial, sans-serif;
font-size: 0.85em; font-size: 0.85em;
@ -109,7 +109,7 @@ a {
font: inherit; font: inherit;
} }
> footer { > .isso-comment-footer {
font-family: "Helvetica", Arial, sans-serif; font-family: "Helvetica", Arial, sans-serif;
font-size: 0.80em; font-size: 0.80em;

6
isso/js/app/isso.js
View File

@ -116,9 +116,9 @@ define(["app/text/html", "app/dom", "app/utils", "app/api", "app/markup", "app/i
el.scrollIntoView(); el.scrollIntoView();
} }
var footer = $("#isso-" + comment.id + " > .text-wrapper > footer"), var footer = $("#isso-" + comment.id + " > .text-wrapper > .isso-comment-footer"),
header = $("#isso-" + comment.id + " > .text-wrapper > header"), header = $("#isso-" + comment.id + " > .text-wrapper > .isso-comment-header"),
text = $("#isso-" + comment.id + " > .text-wrapper > div.text"); text = $("#isso-" + comment.id + " > .text-wrapper > .text");
var form = new Postbox(comment.id); var form = new Postbox(comment.id);
$("a.reply", footer).toggle("click", $("a.reply", footer).toggle("click",

13
isso/js/app/text/comment.html
View File

@ -1,9 +1,9 @@
<article class="isso-comment" id="isso-{{ id | blank }}"> <div class="isso-comment" id="isso-{{ id | blank }}">
<div class="avatar"> <div class="avatar">
<canvas data-hash="{{ hash }}" height="48px" width="48px"></canvas> <canvas data-hash="{{ hash }}" height="48px" width="48px"></canvas>
</div> </div>
<div class="text-wrapper"> <div class="text-wrapper">
<header> <div class="isso-comment-header" role="meta">
{{ if bool(website) }} {{ if bool(website) }}
<a class="author" href="{{ website }}" rel="nofollow"> <a class="author" href="{{ website }}" rel="nofollow">
{{ author | blank : `i18n-comment-anonymous` }} {{ author | blank : `i18n-comment-anonymous` }}
@ -36,8 +36,7 @@
{{ /if }} {{ /if }}
</span> </span>
</div>
</header>
<div class="text"> <div class="text">
{{ if mode | equals : 4 }} {{ if mode | equals : 4 }}
<p>&nbsp;</p> <p>&nbsp;</p>
@ -45,7 +44,7 @@
{{ text }} {{ text }}
{{ /if }} {{ /if }}
</div> </div>
<footer> <div class="isso-comment-footer">
{{ if likes | substract : `dislikes` | notequals : 0 }} {{ if likes | substract : `dislikes` | notequals : 0 }}
<span class="votes">{{ likes | substract : `dislikes` }}</span> <span class="votes">{{ likes | substract : `dislikes` }}</span>
{{ /if }} {{ /if }}
@ -56,8 +55,8 @@
<a class="reply" href="#">{{ i18n-comment-reply }}</a> <a class="reply" href="#">{{ i18n-comment-reply }}</a>
<a class="edit" href="#">{{ i18n-comment-edit }}</a> <a class="edit" href="#">{{ i18n-comment-edit }}</a>
<a class="delete" href="#">{{ i18n-comment-delete }}</a> <a class="delete" href="#">{{ i18n-comment-delete }}</a>
</footer> </div>
<div class="isso-follow-up"> <div class="isso-follow-up">
</div> </div>
</div> </div>
</article> </div>