From 311f65d52b42000c09da5dfecc2a3cd24016cd8c Mon Sep 17 00:00:00 2001 From: Vincent Bernat Date: Sun, 29 Apr 2018 10:37:00 +0200 Subject: [PATCH] embed: fix feed link creation on older browsers When a browser doesn't support DOM manipulation convenience methods, the addition of the feed link was triggering an error because elements created by `$.new()` are regular elements, not elements from our own mini-DOM implementation. Therefore, the `append()` method may be absent. Use `appendChild()` instead. --- isso/js/embed.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/isso/js/embed.js b/isso/js/embed.js index a0a53da..7f7fbbe 100644 --- a/isso/js/embed.js +++ b/isso/js/embed.js @@ -31,7 +31,7 @@ require(["app/lib/ready", "app/config", "app/i18n", "app/api", "app/isso", "app/ var feedLink = $.new('a', i18n.translate('atom-feed')); var feedLinkWrapper = $.new('span.isso-feedlink'); feedLink.href = api.feed($("#isso-thread").getAttribute("data-isso-id")); - feedLinkWrapper.append(feedLink); + feedLinkWrapper.appendChild(feedLink); $("#isso-thread").append(feedLinkWrapper); } $("#isso-thread").append($.new('h4'));