arno/isso
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

api: ensure /feed is easily cacheable by issuing etag/last-modified headers

Browse Source
This commit is contained in:
Vincent Bernat 2018-04-22 12:17:31 +02:00
parent ebca06059a
commit 5c6e78b9c1
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
isso/views/comments.py
View File

@ -950,7 +950,16 @@ class API(object):
ET.ElementTree(feed).write(output, ET.ElementTree(feed).write(output,
encoding='utf-8', encoding='utf-8',
xml_declaration=True) xml_declaration=True)
return XML(output.getvalue(), 200) response = XML(output.getvalue(), 200)
# Add an etag/last-modified value for caching purpose
if comment0 is None:
response.set_etag('empty')
response.last_modified = 0
else:
response.set_etag('{tid}-{id}'.format(**comment0))
response.last_modified = comment0['modified'] or comment0['created']
return response.make_conditional(request)
def preview(self, environment, request): def preview(self, environment, request):
data = request.get_json() data = request.get_json()