return 404 if none found
This commit is contained in:
parent
5d23bff409
commit
27007547bb
@ -18,4 +18,6 @@ def create(app, environ, request, path):
|
|||||||
def get(app, environ, request, path, id=None):
|
def get(app, environ, request, path, id=None):
|
||||||
|
|
||||||
rv = list(app.db.retrieve(path)) if id is None else app.db.get(path, id)
|
rv = list(app.db.retrieve(path)) if id is None else app.db.get(path, id)
|
||||||
|
if not rv:
|
||||||
|
abort(404)
|
||||||
return Response(json.dumps(rv), 200, content_type='application/json')
|
return Response(json.dumps(rv), 200, content_type='application/json')
|
||||||
|
@ -71,6 +71,9 @@ class SQLite(Abstract):
|
|||||||
return
|
return
|
||||||
|
|
||||||
def query2comment(self, query):
|
def query2comment(self, query):
|
||||||
|
if query is None:
|
||||||
|
return None
|
||||||
|
|
||||||
return Comment(
|
return Comment(
|
||||||
text=query[4], author=query[5], email=query[6], website=query[7],
|
text=query[4], author=query[5], email=query[6], website=query[7],
|
||||||
parent=query[8], mode=query[9], id=query[0], created=query[2], modified=query[3]
|
parent=query[8], mode=query[9], id=query[0], created=query[2], modified=query[3]
|
||||||
|
@ -57,3 +57,9 @@ class TestComments(unittest.TestCase):
|
|||||||
|
|
||||||
rv = json.loads(r.data)
|
rv = json.loads(r.data)
|
||||||
assert len(rv) == 20
|
assert len(rv) == 20
|
||||||
|
|
||||||
|
def testGetInvalid(self):
|
||||||
|
|
||||||
|
assert self.get('/comment/path/123').status_code == 404
|
||||||
|
assert self.get('/comment/path/spam').status_code == 404
|
||||||
|
assert self.get('/comment/foo/').status_code == 404
|
||||||
|
Loading…
Reference in New Issue
Block a user