From 1a3f803b966cd32da367978f306b923d433c5cda Mon Sep 17 00:00:00 2001 From: Samuel FORESTIER Date: Sun, 30 Dec 2018 13:55:24 +0100 Subject: [PATCH] Removes potential '//' from email links (#420) If the user specifies a public endpoint as `http[s]://comments.exemple.com/` in configuration, the trailing slash will involve a `//` in the generated email links. --- isso/ext/notifications.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/isso/ext/notifications.py b/isso/ext/notifications.py index 4ff4671..521cc19 100644 --- a/isso/ext/notifications.py +++ b/isso/ext/notifications.py @@ -77,6 +77,8 @@ class SMTP(object): self.isso = isso self.conf = isso.conf.section("smtp") self.public_endpoint = isso.conf.get("server", "public-endpoint") or local("host") + if self.public_endpoint.endswith('/'): + self.public_endpoint = self.public_endpoint.rstrip('/') self.admin_notify = any((n in ("smtp", "SMTP")) for n in isso.conf.getlist("general", "notify")) self.reply_notify = isso.conf.getboolean("general", "reply-notifications")