arno/hashcat
1
0
Fork 0
mirror of https://github.com/hashcat/hashcat.git synced 2025-01-23 14:10:57 +00:00
Code Issues Releases Wiki Activity

tainted string: test #2, try to limit the length of the compute variable

Browse Source
This commit is contained in:
philsmd 2017-02-15 13:45:02 +01:00
parent 7858f37800
commit d21fbe0b2f
No known key found for this signature in database
GPG Key ID: 4F25D016D9D6A8AF
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/shared.c
View File

@ -258,18 +258,18 @@ void setup_environment_variables ()
{ {
static char display[100]; static char display[100];
snprintf (display, sizeof (display) - 1, "DISPLAY=%s", compute); u32 compute_len_max = sizeof (display);
// we only use this check to avoid "tainted string" warnings // we only use this check to avoid "tainted string" warnings
u32 display_len_max = sizeof (display); u32 compute_len = strnlen (compute, compute_len_max);
u32 display_len = strnlen (display, display_len_max); if (compute_len > 0) // should be always true
{
if (compute_len < compute_len_max) // some upper bound is always good
{
snprintf (display, compute_len_max, "DISPLAY=%s", compute);
if (display_len > 0) // should be always true
{
if (display_len < display_len_max) // some upper bound is always good
{
putenv (display); putenv (display);
} }
} }