From caca54b0c62dc740c4fd5e6fb64a5090e5612a31 Mon Sep 17 00:00:00 2001 From: Jens Steube Date: Tue, 10 Aug 2021 18:14:21 +0200 Subject: [PATCH] Deprecated Plugins: Marked plugins 2500/2501 and 16800/16801 as deprecated --- docs/changes.txt | 1 + src/modules/module_02500.c | 9 ++++++++- src/modules/module_02501.c | 9 ++++++++- src/modules/module_16800.c | 9 ++++++++- src/modules/module_16801.c | 9 ++++++++- 5 files changed, 33 insertions(+), 4 deletions(-) diff --git a/docs/changes.txt b/docs/changes.txt index 01adb216f..400bf117c 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -54,6 +54,7 @@ - Commandline: Throw an error if the separator specified by the user with the -p option is not exactly 1 byte - Constants: Make const char * pointers actually const char * const pointers - Deprecated Plugins: Add new module function module_deprecated_notice() to mark a plugin as deprecated and to return a free text user notice +- Deprecated Plugins: Marked plugins 2500/2501 and 16800/16801 as deprecated - Filehandling: Use const char for fopen mode to fix -Wwrite-strings warnings - Hardware Monitor: Added support for OverDrive 7 and 8 based GPUs - HIP Kernels: Dependency on hip/hip runtime.h has been removed to enable easier integration of the HIP backend under Windows diff --git a/src/modules/module_02500.c b/src/modules/module_02500.c index 201ff5dac..ba534ae6d 100644 --- a/src/modules/module_02500.c +++ b/src/modules/module_02500.c @@ -889,6 +889,13 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE return line_len; } +const char *module_deprecated_notice (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra) +{ + const char *deprecated_notice = "The plugin 2500 is deprecated and was replaced with plugin 22000. For more details, please read: https://hashcat.net/forum/thread-10253.html"; + + return deprecated_notice; +} + void module_init (module_ctx_t *module_ctx) { module_ctx->module_context_size = MODULE_CONTEXT_SIZE_CURRENT; @@ -901,7 +908,7 @@ void module_init (module_ctx_t *module_ctx) module_ctx->module_benchmark_salt = MODULE_DEFAULT; module_ctx->module_build_plain_postprocess = MODULE_DEFAULT; module_ctx->module_deep_comp_kernel = module_deep_comp_kernel; - module_ctx->module_deprecated_notice = MODULE_DEFAULT; + module_ctx->module_deprecated_notice = module_deprecated_notice; module_ctx->module_dgst_pos0 = module_dgst_pos0; module_ctx->module_dgst_pos1 = module_dgst_pos1; module_ctx->module_dgst_pos2 = module_dgst_pos2; diff --git a/src/modules/module_02501.c b/src/modules/module_02501.c index 8f1f1731f..c789a037e 100644 --- a/src/modules/module_02501.c +++ b/src/modules/module_02501.c @@ -886,6 +886,13 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE return line_len; } +const char *module_deprecated_notice (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra) +{ + const char *deprecated_notice = "The plugin 2501 is deprecated and was replaced with plugin 22001. For more details, please read: https://hashcat.net/forum/thread-10253.html"; + + return deprecated_notice; +} + void module_init (module_ctx_t *module_ctx) { module_ctx->module_context_size = MODULE_CONTEXT_SIZE_CURRENT; @@ -898,7 +905,7 @@ void module_init (module_ctx_t *module_ctx) module_ctx->module_benchmark_salt = MODULE_DEFAULT; module_ctx->module_build_plain_postprocess = MODULE_DEFAULT; module_ctx->module_deep_comp_kernel = module_deep_comp_kernel; - module_ctx->module_deprecated_notice = MODULE_DEFAULT; + module_ctx->module_deprecated_notice = module_deprecated_notice; module_ctx->module_dgst_pos0 = module_dgst_pos0; module_ctx->module_dgst_pos1 = module_dgst_pos1; module_ctx->module_dgst_pos2 = module_dgst_pos2; diff --git a/src/modules/module_16800.c b/src/modules/module_16800.c index 2439703c5..f6d53ed22 100644 --- a/src/modules/module_16800.c +++ b/src/modules/module_16800.c @@ -497,6 +497,13 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE return line_len; } +const char *module_deprecated_notice (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra) +{ + const char *deprecated_notice = "The plugin 16800 is deprecated and was replaced with plugin 22000. For more details, please read: https://hashcat.net/forum/thread-10253.html"; + + return deprecated_notice; +} + void module_init (module_ctx_t *module_ctx) { module_ctx->module_context_size = MODULE_CONTEXT_SIZE_CURRENT; @@ -509,7 +516,7 @@ void module_init (module_ctx_t *module_ctx) module_ctx->module_benchmark_salt = MODULE_DEFAULT; module_ctx->module_build_plain_postprocess = MODULE_DEFAULT; module_ctx->module_deep_comp_kernel = module_deep_comp_kernel; - module_ctx->module_deprecated_notice = MODULE_DEFAULT; + module_ctx->module_deprecated_notice = module_deprecated_notice; module_ctx->module_dgst_pos0 = module_dgst_pos0; module_ctx->module_dgst_pos1 = module_dgst_pos1; module_ctx->module_dgst_pos2 = module_dgst_pos2; diff --git a/src/modules/module_16801.c b/src/modules/module_16801.c index fb1edf8ec..070d4b976 100644 --- a/src/modules/module_16801.c +++ b/src/modules/module_16801.c @@ -573,6 +573,13 @@ int module_hash_encode (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSE return line_len; } +const char *module_deprecated_notice (MAYBE_UNUSED const hashconfig_t *hashconfig, MAYBE_UNUSED const user_options_t *user_options, MAYBE_UNUSED const user_options_extra_t *user_options_extra) +{ + const char *deprecated_notice = "The plugin 16801 is deprecated and was replaced with plugin 22001. For more details, please read: https://hashcat.net/forum/thread-10253.html"; + + return deprecated_notice; +} + void module_init (module_ctx_t *module_ctx) { module_ctx->module_context_size = MODULE_CONTEXT_SIZE_CURRENT; @@ -585,7 +592,7 @@ void module_init (module_ctx_t *module_ctx) module_ctx->module_benchmark_salt = MODULE_DEFAULT; module_ctx->module_build_plain_postprocess = MODULE_DEFAULT; module_ctx->module_deep_comp_kernel = module_deep_comp_kernel; - module_ctx->module_deprecated_notice = MODULE_DEFAULT; + module_ctx->module_deprecated_notice = module_deprecated_notice; module_ctx->module_dgst_pos0 = module_dgst_pos0; module_ctx->module_dgst_pos1 = module_dgst_pos1; module_ctx->module_dgst_pos2 = module_dgst_pos2;