mirror of https://github.com/hashcat/hashcat.git
If module_hash_binary_parse is completely unable to successfully parse out any hashes, up until now the output has been ``` Hashfile 'foo': Success ``` which is less than helpful. This patch allows (but does not require) m_h_binary_parse to report a useful error response, by returning a negative value. Modules which continue to return '0 hashes' will get the same less-than-useful behaviour they always hace. I've also modified the LUKS module to report a useful error, as a proof of concept. Further expansions on this could include: * Applying similar behaviour to module_hash_binary_count, so it too can report errors when trying to count hashes. This would require more co-ordinated change, because m_h_binary_count already uses -1 to indicate a system error. * Allow and encourage modules to print their own errors and warnings during parsing. This would allow for situations where a single hash in a multi-hash file could be reported as malformed, without having to fail the whole parse. However, implementing this would, I expect, require modules to have access to `hashcat_ctx`, which... yeah. Not so straightforward.pull/2372/head
parent
c5d2d5396f
commit
b4204d265d
Loading…
Reference in new issue