From fe3395730370e91d46c18d0a3b801f43b6cdd4aa Mon Sep 17 00:00:00 2001 From: philsmd Date: Wed, 15 Feb 2017 12:41:32 +0100 Subject: [PATCH] rule engine: prevent integer underflow and dead code --- src/rp.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/rp.c b/src/rp.c index 88fe093b8..9ada09ad9 100644 --- a/src/rp.c +++ b/src/rp.c @@ -663,6 +663,7 @@ int kernel_rule_to_cpu_rule (char *rule_buf, kernel_rule_t *rule) break; case 0: + if (rule_pos == 0) return -1; return rule_pos - 1; default: @@ -670,12 +671,7 @@ int kernel_rule_to_cpu_rule (char *rule_buf, kernel_rule_t *rule) } } - if (rule_cnt > 0) - { - return rule_pos; - } - - return -1; + return rule_pos; } bool kernel_rules_has_noop (const kernel_rule_t *kernel_rules_buf, const u32 kernel_rules_cnt)