From a4616e6c6d2b69aa4e4c39f6bccc339eea9a8655 Mon Sep 17 00:00:00 2001
From: philsmd <philsmd@hashcat.net>
Date: Mon, 21 Aug 2017 09:14:49 +0200
Subject: [PATCH] fixes #1338: hexify also all password of format $HEX[]

---
 docs/changes.txt |  1 +
 src/convert.c    | 13 +++++++++++++
 2 files changed, 14 insertions(+)

diff --git a/docs/changes.txt b/docs/changes.txt
index edee965e8..a5a6f9543 100644
--- a/docs/changes.txt
+++ b/docs/changes.txt
@@ -26,6 +26,7 @@
 - Fixed an invalid progress value in status view if words from the base wordlist get rejected because of length
 - Fixed a parser error for mode -m 9820 = MS Office <= 2003 $3, SHA1 + RC4, collider #2
 - Fixed a problem with changed current working directory, for instance by using --restore together with --remove
+- Fixed a problem with the conversion to the $HEX[] format: convert/hexify also all passwords of the format $HEX[]
 - Fixed the calculation of device_name_chksum; should be done for each iteration
 - Fixed the estimated time value whenever the value is very large and overflows
 - Fixed the parsing of command line options. It doesn't show two times the same error about an invalid option anymore
diff --git a/src/convert.c b/src/convert.c
index 3c2f591ff..079043780 100644
--- a/src/convert.c
+++ b/src/convert.c
@@ -152,6 +152,19 @@ bool need_hexify (const u8 *buf, const int len, const char separator, bool alway
     }
   }
 
+  // also test if the password is of the format $HEX[]:
+
+  if (rc == false)
+  {
+    if ((len & 1) == 0)
+    {
+      if (is_hexify (buf, len))
+      {
+        rc = true;
+      }
+    }
+  }
+
   return rc;
 }