From 7077865b0d1ff06a3c7f72fda5cf713647e0e4a0 Mon Sep 17 00:00:00 2001 From: Arseniy Sharoglazov Date: Wed, 17 Apr 2024 18:58:00 +0300 Subject: [PATCH] Removing unnecessary memset calls in potfile_remove_parse --- docs/changes.txt | 1 + src/potfile.c | 15 --------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/docs/changes.txt b/docs/changes.txt index 283e3c0d4..99dd0e5eb 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -67,6 +67,7 @@ ## - DEScrypt Kernel (1500): Improved performance from 950MH/s to 2200MH/s (RX6900XT) on HIP backend by workaround invalid compile time optimizer +- Performance of --show feature has been improved by removing unnecessary memset calls in potfile_remove_parse function. ## ## Bugs diff --git a/src/potfile.c b/src/potfile.c index a912e1f50..e3b079e0f 100644 --- a/src/potfile.c +++ b/src/potfile.c @@ -535,21 +535,6 @@ int potfile_remove_parse (hashcat_ctx_t *hashcat_ctx) if (line_hash_len == 0) continue; - if (hash_buf.salt) - { - memset (hash_buf.salt, 0, sizeof (salt_t)); - } - - if (hash_buf.esalt) - { - memset (hash_buf.esalt, 0, hashconfig->esalt_size); - } - - if (hash_buf.hook_salt) - { - memset (hash_buf.hook_salt, 0, hashconfig->hook_salt_size); - } - if (module_ctx->module_hash_decode_potfile != MODULE_DEFAULT) { if (module_ctx->module_potfile_custom_check != MODULE_DEFAULT)