arno/hashcat
1
0
Fork 0
mirror of https://github.com/hashcat/hashcat.git synced 2025-06-29 19:32:36 +00:00
Code Issues Releases Wiki Activity

Merge pull request #1110 from hashcat/revert-1109-master

Browse Source 
Revert "tainted string: maybe strdup () helps us out"
This commit is contained in:
Jens Steube 2017-02-15 14:17:58 +01:00 committed by GitHub
commit a07875e25d
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/shared.c
View File

@ -256,10 +256,6 @@ void setup_environment_variables ()
if (compute) if (compute)
{ {
// fix for coverity "TAINTED_STRING" issue (using the environment variable directly could be "dangerous")
compute = strdup (compute);
static char display[100]; static char display[100];
u32 compute_len_max = sizeof (display); u32 compute_len_max = sizeof (display);
@ -277,8 +273,6 @@ void setup_environment_variables ()
putenv (display); putenv (display);
} }
} }
free (compute);
} }
else else
{ {