Merge pull request #1110 from hashcat/revert-1109-master

Revert "tainted string: maybe strdup () helps us out"
7 years ago · a07875e25d
parent ad24f5d2ed 899b120316
commit a07875e25d
1 changed files with 0 additions and 6 deletions
--- a/src/shared.c
+++ b/src/shared.c
@ -256,10 +256,6 @@ void setup_environment_variables ()

  if (compute)
  {
-    // fix for coverity "TAINTED_STRING" issue (using the environment variable directly could be "dangerous")
-
-    compute = strdup (compute);
-
    static char display[100];

    u32 compute_len_max = sizeof (display);
@ -277,8 +273,6 @@ void setup_environment_variables ()
        putenv (display);
      }
    }
-
-    free (compute);
  }
  else
  {