1
0
mirror of https://github.com/hashcat/hashcat.git synced 2024-11-22 16:18:09 +00:00

Fixed error handling logic in monitor thread to not return in case of error (disc full, permission error, ...) but to retry instead

This commit is contained in:
Jens Steube 2021-06-04 09:48:27 +02:00
parent 7024f31b58
commit 918a621506
2 changed files with 29 additions and 8 deletions

View File

@ -27,6 +27,7 @@
- Fixed error message in -a 9 mode with rules in case number of words from wordlist are not in sync with number of unique salts
- Fixed false negatives with TrueCrypt/VeraCrypt in case zip or gzip compressed files were used as keyfiles
- Fixed error handling logic in monitor thread to not return in case of error (disc full, permission error, ...) but to retry instead
##
## Improvements

View File

@ -167,9 +167,14 @@ static int monitor (hashcat_ctx_t *hashcat_ctx)
if (restore_left == 0)
{
const int rc = cycle_restore (hashcat_ctx);
// Can't return from monitor for that reasons, see:
// https://github.com/hashcat/hashcat/issues/2704
//
//const int rc = cycle_restore (hashcat_ctx);
//
//if (rc == -1) return -1;
if (rc == -1) return -1;
cycle_restore (hashcat_ctx);
restore_left = user_options->restore_timer;
}
@ -197,9 +202,14 @@ static int monitor (hashcat_ctx_t *hashcat_ctx)
{
hashes->digests_saved = hashes->digests_done;
const int rc = save_hash (hashcat_ctx);
// Can't return from monitor for that reasons, see:
// https://github.com/hashcat/hashcat/issues/2704
//
// const int rc = save_hash (hashcat_ctx);
//
// if (rc == -1) return -1;
if (rc == -1) return -1;
save_hash (hashcat_ctx);
}
remove_left = user_options->remove_timer;
@ -313,9 +323,14 @@ static int monitor (hashcat_ctx_t *hashcat_ctx)
{
if (hashes->digests_saved != hashes->digests_done)
{
const int rc = save_hash (hashcat_ctx);
// Can't return from monitor for that reasons, see:
// https://github.com/hashcat/hashcat/issues/2704
//
// const int rc = save_hash (hashcat_ctx);
//
// if (rc == -1) return -1;
if (rc == -1) return -1;
save_hash (hashcat_ctx);
}
}
@ -323,9 +338,14 @@ static int monitor (hashcat_ctx_t *hashcat_ctx)
if (restore_check == true)
{
const int rc = cycle_restore (hashcat_ctx);
// Can't return from monitor for that reasons, see:
// https://github.com/hashcat/hashcat/issues/2704
//
// const int rc = cycle_restore (hashcat_ctx);
//
// if (rc == -1) return -1;
if (rc == -1) return -1;
cycle_restore (hashcat_ctx);
}
return 0;