arno/hashcat
1
0
Fork 0
mirror of https://github.com/hashcat/hashcat.git synced 2025-01-13 09:11:01 +00:00
Code Issues Releases Wiki Activity

Fix missing free() for memory allocated with asprintf()

Browse Source
This commit is contained in:
jsteube 2017-10-04 13:04:58 +02:00
parent 6c251d48a4
commit 583849cd23
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/hashes.c
View File

@ -136,6 +136,9 @@ int save_hash (hashcat_ctx_t *hashcat_ctx)
{ {
event_log_error (hashcat_ctx, "%s: %s", new_hashfile, strerror (errno)); event_log_error (hashcat_ctx, "%s: %s", new_hashfile, strerror (errno));
free (new_hashfile);
free (old_hashfile);
return -1; return -1;
} }
@ -145,6 +148,9 @@ int save_hash (hashcat_ctx_t *hashcat_ctx)
event_log_error (hashcat_ctx, "%s: %s", new_hashfile, strerror (errno)); event_log_error (hashcat_ctx, "%s: %s", new_hashfile, strerror (errno));
free (new_hashfile);
free (old_hashfile);
return -1; return -1;
} }
@ -211,6 +217,9 @@ int save_hash (hashcat_ctx_t *hashcat_ctx)
{ {
event_log_error (hashcat_ctx, "Rename file '%s' to '%s': %s", hashfile, old_hashfile, strerror (errno)); event_log_error (hashcat_ctx, "Rename file '%s' to '%s': %s", hashfile, old_hashfile, strerror (errno));
free (new_hashfile);
free (old_hashfile);
return -1; return -1;
} }
@ -220,11 +229,17 @@ int save_hash (hashcat_ctx_t *hashcat_ctx)
{ {
event_log_error (hashcat_ctx, "Rename file '%s' to '%s': %s", new_hashfile, hashfile, strerror (errno)); event_log_error (hashcat_ctx, "Rename file '%s' to '%s': %s", new_hashfile, hashfile, strerror (errno));
free (new_hashfile);
free (old_hashfile);
return -1; return -1;
} }
unlink (old_hashfile); unlink (old_hashfile);
free (new_hashfile);
free (old_hashfile);
return 0; return 0;
} }

2
src/opencl.c
View File

@ -4458,6 +4458,8 @@ int opencl_session_begin (hashcat_ctx_t *hashcat_ctx)
CL_rc = hc_clBuildProgram (hashcat_ctx, device_param->program, 1, &device_param->device, build_opts_update, NULL, NULL); CL_rc = hc_clBuildProgram (hashcat_ctx, device_param->program, 1, &device_param->device, build_opts_update, NULL, NULL);
free (build_opts_update);
//if (CL_rc == -1) return -1; //if (CL_rc == -1) return -1;
size_t build_log_size = 0; size_t build_log_size = 0;

4
src/shared.c
View File

@ -304,11 +304,13 @@ void setup_environment_variables ()
if (compute) if (compute)
{ {
static char *display; char *display;
hc_asprintf (&display, "DISPLAY=%s", compute); hc_asprintf (&display, "DISPLAY=%s", compute);
putenv (display); putenv (display);
free (display);
} }
else else
{ {